chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc - Issue 2858013002: PS - Showing permission prompt for activeTab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

Issue 2858013002: PS - Showing permission prompt for activeTab (Closed)

Patch Set: Changed permission prompt message Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/active_tab_unittest.cc ('K') | « chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm ('k') | components/user_manager/user.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

index 3ac2aad73a91ff6b16669548fa43c09893c00b2d..7bece9ae2bac59fb62cec2cdea099064e4ba0893 100644

--- a/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc

@@ -128,7 +128,7 @@ IN_PROC_BROWSER_TEST_F(ScrollbarTest, LongPromptScrollbar) {

PermissionIDSet()));

}

std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt = CreatePrompt();

- prompt->SetPermissions(permissions,

+ prompt->AddPermissions(permissions,

ExtensionInstallPrompt::REGULAR_PERMISSIONS);

ASSERT_TRUE(IsScrollbarVisible(std::move(prompt)))

<< "Scrollbar is not visible";

@@ -143,7 +143,7 @@ IN_PROC_BROWSER_TEST_F(ScrollbarTest, ScrollbarRegression) {

permissions.push_back(PermissionMessage(permission_string,

PermissionIDSet()));

std::unique_ptr<ExtensionInstallPrompt::Prompt> prompt = CreatePrompt();

- prompt->SetPermissions(permissions,

+ prompt->AddPermissions(permissions,

ExtensionInstallPrompt::REGULAR_PERMISSIONS);

ASSERT_FALSE(IsScrollbarVisible(std::move(prompt))) << "Scrollbar is visible";

}