Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1185)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

Issue 2858013002: PS - Showing permission prompt for activeTab (Closed)
Patch Set: Update a unittest (.mm) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
index a15c22a3571cfdfca51a8cbbb95e558c4380d575..fc11f65b29628eb6205ba36a6fb68d827aaa8bad 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
@@ -83,7 +83,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) {
PermissionMessages permissions;
permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
PermissionIDSet()));
- prompt->SetPermissions(permissions, type);
+ prompt->AddPermissions(permissions, type);
base::string16 permissionString = prompt->GetPermission(0, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
@@ -141,7 +141,7 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalOK) {
PermissionMessages permissions;
permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
PermissionIDSet()));
- prompt->SetPermissions(permissions, type);
+ prompt->AddPermissions(permissions, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc]
@@ -171,13 +171,13 @@ TEST_F(ExtensionInstallViewControllerTest, MultipleWarnings) {
PermissionMessages permissions;
permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
PermissionIDSet()));
- one_warning_prompt->SetPermissions(permissions, type);
+ one_warning_prompt->AddPermissions(permissions, type);
std::unique_ptr<ExtensionInstallPrompt::Prompt> two_warnings_prompt(
chrome::BuildExtensionInstallPrompt(extension_.get()));
permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 2"),
PermissionIDSet()));
- two_warnings_prompt->SetPermissions(permissions, type);
+ two_warnings_prompt->AddPermissions(permissions, type);
base::scoped_nsobject<ExtensionInstallViewController> controller1(
[[ExtensionInstallViewController alloc]
@@ -322,7 +322,7 @@ TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
PermissionMessages permissions;
permissions.push_back(PermissionMessage(base::UTF8ToUTF16("warning 1"),
PermissionIDSet()));
- prompt->SetPermissions(permissions, type);
+ prompt->AddPermissions(permissions, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc]
@@ -355,7 +355,7 @@ TEST_F(ExtensionInstallViewControllerTest, PermissionsDetails) {
base::UTF8ToUTF16("warning 1"),
PermissionIDSet(),
std::vector<base::string16>(1, base::UTF8ToUTF16("Detail 1"))));
- prompt->SetPermissions(permissions, type);
+ prompt->AddPermissions(permissions, type);
prompt->SetIsShowingDetails(
ExtensionInstallPrompt::PERMISSIONS_DETAILS, 0, true);
base::string16 permissionString = prompt->GetPermissionsDetails(0, type);

Powered by Google App Engine
This is Rietveld 408576698