Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2557)

Unified Diff: chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc

Issue 2858013002: PS - Showing permission prompt for activeTab (Closed)
Patch Set: Update a unittest (.mm) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
diff --git a/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc b/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9cca47521becd7c3dc0389c072f433fd8df79168
--- /dev/null
+++ b/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
@@ -0,0 +1,85 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos.h"
+
+#include <string>
+
+#include "base/run_loop.h"
+#include "chrome/browser/chromeos/extensions/public_session_permission_helper.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "chromeos/login/scoped_test_public_session_login_state.h"
+#include "extensions/browser/extension_dialog_auto_confirm.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/extension_builder.h"
+#include "extensions/common/value_builder.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+namespace {
+
+const char kWhitelistedId[] = "cbkkbcmdlboombapidmoeolnmdacpkch";
+// Use an extension ID that will never be whitelisted.
+const char kNonWhitelistedId[] = "bogus";
+
+scoped_refptr<Extension> CreateExtension(const std::string& id) {
+ return ExtensionBuilder()
+ .SetManifest(
+ DictionaryBuilder().Set("name", "test").Set("version", "0.1").Build())
+ .SetID(id)
+ .Build();
+}
+
+} // namespace
+
+class ActiveTabPermissionGranterDelegateChromeOSTest
+ : public ChromeRenderViewHostTestHarness {
+ protected:
+ void SetUp() override;
+ void TearDown() override;
+
+ ActiveTabPermissionGranterDelegateChromeOS delegate_;
+ chromeos::ScopedTestPublicSessionLoginState login_state_;
+};
+
+void ActiveTabPermissionGranterDelegateChromeOSTest::SetUp() {
+ ChromeRenderViewHostTestHarness::SetUp();
+}
+
+void ActiveTabPermissionGranterDelegateChromeOSTest::TearDown() {
+ permission_helper::ResetPermissionsForTesting();
+ ChromeRenderViewHostTestHarness::TearDown();
+}
+
+TEST_F(ActiveTabPermissionGranterDelegateChromeOSTest, GrantedForWhitelisted) {
+ auto extension = CreateExtension(kWhitelistedId);
+ EXPECT_TRUE(delegate_.ShouldGrantActiveTab(extension.get(), nullptr));
+}
+
+TEST_F(ActiveTabPermissionGranterDelegateChromeOSTest,
+ RejectedForNonWhitelisted) {
+ auto extension = CreateExtension(kNonWhitelistedId);
+ // Deny the permission request.
+ ScopedTestDialogAutoConfirm auto_confirm(ScopedTestDialogAutoConfirm::CANCEL);
+ // First request is always rejected (by design).
+ EXPECT_FALSE(delegate_.ShouldGrantActiveTab(extension.get(), nullptr));
+ // Spin the loop, allowing the dialog to be resolved.
+ base::RunLoop().RunUntilIdle();
+ // Dialog result is propagated here, permission request is rejected.
+ EXPECT_FALSE(delegate_.ShouldGrantActiveTab(extension.get(), nullptr));
+}
+
+TEST_F(ActiveTabPermissionGranterDelegateChromeOSTest,
+ GrantedForNonWhitelisted) {
+ auto extension = CreateExtension(kNonWhitelistedId);
+ // Allow the permission request.
+ ScopedTestDialogAutoConfirm auto_confirm(ScopedTestDialogAutoConfirm::ACCEPT);
+ EXPECT_FALSE(delegate_.ShouldGrantActiveTab(extension.get(), nullptr));
+ base::RunLoop().RunUntilIdle();
+ // The permission request is granted now.
+ EXPECT_TRUE(delegate_.ShouldGrantActiveTab(extension.get(), nullptr));
+}
+
+} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698