Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4606)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/extensions/extension_install_prompt.cc

Issue 2858013002: PS - Showing permission prompt for activeTab (Closed)
Patch Set: Test - delegate is set and works Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/active_tab_permission_granter.cc ('K') | « chrome/browser/extensions/active_tab_unittest.cc ('k') | components/user_manager/user.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_prompt.cc
diff --git a/chrome/browser/extensions/extension_install_prompt.cc b/chrome/browser/extensions/extension_install_prompt.cc
index f09336939a68e49be532c5cb564ebf8ccf507d3f..897208f685a4afc22f0387fcf87a5c0ed55a54ac 100644
--- a/chrome/browser/extensions/extension_install_prompt.cc
+++ b/chrome/browser/extensions/extension_install_prompt.cc
@@ -166,10 +166,6 @@ void ExtensionInstallPrompt::Prompt::SetPermissions(
InstallPromptPermissions& install_permissions =
GetPermissionsForType(permissions_type);
- install_permissions.permissions.clear();
- install_permissions.details.clear();
- install_permissions.is_showing_details.clear();
-
for (const PermissionMessage& msg : permissions) {
install_permissions.permissions.push_back(msg.message());
// Add a dash to the front of each permission detail.
« chrome/browser/extensions/active_tab_permission_granter.cc ('K') | « chrome/browser/extensions/active_tab_unittest.cc ('k') | components/user_manager/user.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698