PS - Showing permission prompt for activeTab

chrome/browser/extensions/active_tab_permission_granter.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_ACTIVE_TAB_PERMISSION_GRANTER_H_
 #define CHROME_BROWSER_EXTENSIONS_ACTIVE_TAB_PERMISSION_GRANTER_H_
 
 #include <set>
 #include <string>
 
@@ skipping 14 matching lines @@
 
 class Extension;
 class ExtensionRegistry;
 
 // Responsible for granting and revoking tab-specific permissions to extensions
 // with the activeTab or tabCapture permission.
 class ActiveTabPermissionGranter
     : public content::WebContentsObserver,
       public extensions::ExtensionRegistryObserver {
  public:
+  // Platform specific delegate.
+  class Delegate {
+   public:
+    virtual ~Delegate() {}
+    // Platform specific check whether the user granted activeTab permission.

[Devlin, 2017/05/12 14:56:45]

I think rather than "whether the user granted activeTab", this should be
something like "whether the activeTab permission is allowed".  Other delegates
might gate this on something other than user dialogs.

[Ivan Šandrk, 2017/05/12 18:27:44]

Good point, done.

+    virtual bool ActiveTabPermissionGranted(

[Devlin, 2017/05/12 14:56:45]

"ActiveTabPermissionGranted" is a strange name for a method that determines *if*
activeTab should be granted.  Maybe "ShouldGrantActiveTab"?

[Ivan Šandrk, 2017/05/12 18:27:44]

Another good one, done.

+        const Extension* extension, content::WebContents* web_contents) = 0;
+  };
+
   ActiveTabPermissionGranter(content::WebContents* web_contents,
                              int tab_id,
                              Profile* profile);
   ~ActiveTabPermissionGranter() override;
 
+  // Platform specific delegate should be set during startup. |delegate| is a
+  // singleton instance and is leaked.
+  static void SetPlatformDelegate(Delegate* delegate);
+
   // If |extension| has the activeTab or tabCapture permission, grants
   // tab-specific permissions to it until the next page navigation or refresh.
   void GrantIfRequested(const Extension* extension);
 
   // Clears tab-specific permissions for all extensions. Used only for testing.
   void RevokeForTesting();
 
  private:
   // content::WebContentsObserver implementation.
   void DidFinishNavigation(
@@ skipping 19 matching lines @@
   // Listen to extension unloaded notifications.
   ScopedObserver<ExtensionRegistry, ExtensionRegistryObserver>
       extension_registry_observer_;
 
   DISALLOW_COPY_AND_ASSIGN(ActiveTabPermissionGranter);
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_ACTIVE_TAB_PERMISSION_GRANTER_H_