Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Side by Side Diff: chrome/browser/resources/print_preview/settings/layout_settings.js

Issue 2857983007: Print Preview: Make getChildElement return required HTMLElement (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('print_preview', function() { 5 cr.define('print_preview', function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * Creates a LayoutSettings object. This object encapsulates all settings and 9 * Creates a LayoutSettings object. This object encapsulates all settings and
10 * logic related to layout mode (portrait/landscape). 10 * logic related to layout mode (portrait/landscape).
(...skipping 28 matching lines...) Expand all
39 39
40 /** @override */ 40 /** @override */
41 set isEnabled(isEnabled) { 41 set isEnabled(isEnabled) {
42 this.select_.disabled = !isEnabled; 42 this.select_.disabled = !isEnabled;
43 }, 43 },
44 44
45 /** @override */ 45 /** @override */
46 enterDocument: function() { 46 enterDocument: function() {
47 print_preview.SettingsSection.prototype.enterDocument.call(this); 47 print_preview.SettingsSection.prototype.enterDocument.call(this);
48 this.tracker.add( 48 this.tracker.add(
49 assert(this.select_), 'change', this.onSelectChange_.bind(this)); 49 this.select_, 'change', this.onSelectChange_.bind(this));
50 this.tracker.add( 50 this.tracker.add(
51 this.landscapeTicketItem_, 51 this.landscapeTicketItem_,
52 print_preview.ticket_items.TicketItem.EventType.CHANGE, 52 print_preview.ticket_items.TicketItem.EventType.CHANGE,
53 this.onLandscapeTicketItemChange_.bind(this)); 53 this.onLandscapeTicketItemChange_.bind(this));
54 }, 54 },
55 55
56 /** 56 /**
57 * Called when the select element is changed. Updates the print ticket 57 * Called when the select element is changed. Updates the print ticket
58 * layout selection. 58 * layout selection.
59 * @private 59 * @private
60 */ 60 */
61 onSelectChange_: function() { 61 onSelectChange_: function() {
62 var select = this.select_; 62 var select = this.select_;
63 var isLandscape = 63 var isLandscape =
64 select.options[select.selectedIndex].value == 'landscape'; 64 select.options[select.selectedIndex].value == 'landscape';
65 this.landscapeTicketItem_.updateValue(isLandscape); 65 this.landscapeTicketItem_.updateValue(isLandscape);
66 }, 66 },
67 67
68 /** 68 /**
69 * @return {HTMLSelectElement} Select element containing the layout options. 69 * @return {!HTMLSelectElement} Select element containing the layout
70 * options.
70 * @private 71 * @private
71 */ 72 */
72 get select_() { 73 get select_() {
73 return /** @type {HTMLSelectElement} */( 74 return /** @type {!HTMLSelectElement} */(
dpapad 2017/05/04 23:59:49 Same here.
74 this.getChildElement('.layout-settings-select')); 75 this.getChildElement('.layout-settings-select'));
75 }, 76 },
76 77
77 /** 78 /**
78 * Called when the print ticket store changes state. Updates the state of 79 * Called when the print ticket store changes state. Updates the state of
79 * the radio buttons and hides the setting if necessary. 80 * the radio buttons and hides the setting if necessary.
80 * @private 81 * @private
81 */ 82 */
82 onLandscapeTicketItemChange_: function() { 83 onLandscapeTicketItemChange_: function() {
83 if (this.isAvailable()) { 84 if (this.isAvailable()) {
84 var select = this.select_; 85 var select = this.select_;
85 var valueToSelect = 86 var valueToSelect =
86 this.landscapeTicketItem_.getValue() ? 'landscape' : 'portrait'; 87 this.landscapeTicketItem_.getValue() ? 'landscape' : 'portrait';
87 for (var i = 0; i < select.options.length; i++) { 88 for (var i = 0; i < select.options.length; i++) {
88 if (select.options[i].value == valueToSelect) { 89 if (select.options[i].value == valueToSelect) {
89 select.selectedIndex = i; 90 select.selectedIndex = i;
90 break; 91 break;
91 } 92 }
92 } 93 }
93 } 94 }
94 this.updateUiStateInternal(); 95 this.updateUiStateInternal();
95 } 96 }
96 }; 97 };
97 98
98 // Export 99 // Export
99 return { 100 return {
100 LayoutSettings: LayoutSettings 101 LayoutSettings: LayoutSettings
101 }; 102 };
102 }); 103 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698