Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: components/net_log/resources/net_export.html

Issue 2857973003: Add a "Show File" button to chrome://net-export/ (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/net_log/net_export_ui_constants.cc ('k') | components/net_log/resources/net_export.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/net_log/resources/net_export.html
diff --git a/components/net_log/resources/net_export.html b/components/net_log/resources/net_export.html
index a887c0c58b942a1e27a260749b2d0876adb7e6ae..b612b7ea30e5971b81a24bd495603dbf2bcaae8f 100644
--- a/components/net_log/resources/net_export.html
+++ b/components/net_log/resources/net_export.html
@@ -94,7 +94,7 @@
</div>
<div class="outline-box">
- <b>FILE:</b> <span id='file-path-logging'></span> <br/>
+ <b>FILE:</b> <span id="file-path-logging"></span> <br/>
<b>OPTIONS:</b> <span id="capture-mode-logging"></span>
</div>
</div>
@@ -110,16 +110,11 @@
<h2>Log file written</h2>
<if expr="is_ios or is_android">
- <button id="mobile-email">
- Email Log
- <div class="warning" id="mobile-private-data-text" hidden>
eroman 2017/05/03 18:35:47 This was unused after my previous CL, just cleanin
- Log contains private information
- </div>
+ <button id="mobile-email">Email Log</button>
+ </if>
- <div class="warning" id="mobile-send-old-log-text" hidden>
- Log file from previous session
- </div>
- </button>
+ <if expr="not(is_ios or is_android)">
+ <button id="show-file">Show File</button>
</if>
<button id="startover">
@@ -136,8 +131,9 @@
</if>
</div>
+ <!-- TODO(eroman): This is duplicated with the logging state -->
<div class="outline-box">
- <b>FILE:</b> <span id='file-path-stopped'></span> <br/>
+ <b>FILE:</b> <span id="file-path-stopped"></span> <br/>
<b>OPTIONS:</b> <span id="capture-mode-stopped"></span>
</div>
« no previous file with comments | « components/net_log/net_export_ui_constants.cc ('k') | components/net_log/resources/net_export.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698