Extract CdmManager from MojoCdmService.

media/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/buildflag_header.gni")
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/features.gni")
 import("//build/config/linux/pkg_config.gni")
 import("//build/config/ui.gni")
@@ skipping 359 matching lines @@
 
   if (media_use_libvpx) {
     sources += [
       "filters/vpx_video_decoder.cc",
       "filters/vpx_video_decoder.h",
     ]
     deps += [ "//third_party/libvpx" ]
   }
 
   if (disable_ffmpeg_video_decoders) {
-      sources -= [
-        "filters/decrypting_video_decoder.cc",
-        "filters/decrypting_video_decoder.h",
-      ]
+    sources -= [
+      "filters/decrypting_video_decoder.cc",
+      "filters/decrypting_video_decoder.h",
+    ]
   }
 
   if (is_android) {
     sources -= [
       "filters/decrypting_audio_decoder.cc",
       "filters/decrypting_audio_decoder.h",
     ]
     sources += [
       "filters/android/media_codec_audio_decoder.cc",
       "filters/android/media_codec_audio_decoder.h",
@@ skipping 115 matching lines @@
 
   if (use_udev) {
     deps += [ "//device/udev_linux" ]
     sources += [
       "device_monitors/device_monitor_udev.cc",
       "device_monitors/device_monitor_udev.h",
     ]
   }
 }
 
+# Must not be a source_set() because CdmManager exposes a static singleton,
+# shared by multiple component()s.
+component("cdm_manager") {
+  sources = [
+    "cdm/cdm_manager.cc",
+    "cdm/cdm_manager.h",
+  ]
+  configs += [ ":media_implementation" ]

[xhwang, 2017/05/04 20:46:11]

Typically we only use this on the "media" target. Now, since we are depending on
"media", when we include a header file with MEDIA_EXPORT in "media", since we
have "media implementation", the MEDIA_EXPORT will be treated as "import"
instead of "export". I remember this will cause issues on some bots/platforms.

To avoid that, the right thing to do is to have a cdm_manager_export.h. It seems
overkill, but I don't know any better way to work around it.

[sandersd (OOO until July 31), 2017/05/04 21:03:35]

I have restricted the visibility and added a comment to explain this.

+  deps = [
+    ":media",
+    "//base",
+  ]
+}
+
 static_library("cdm_paths") {
   sources = [
     "cdm/cdm_paths.cc",
     "cdm/cdm_paths.h",
   ]
   deps = [
     "//base",
   ]
 }
 
@@ skipping 123 matching lines @@
     ]
 
     deps += [
       "//media/ffmpeg:ffmpeg_unittests",
 
       # Direct dependency needed for the config
       "//third_party/opus",
     ]
 
     if (!disable_ffmpeg_video_decoders) {
-      sources += [
-        "filters/ffmpeg_video_decoder_unittest.cc",
-      ]
+      sources += [ "filters/ffmpeg_video_decoder_unittest.cc" ]
     }
   }
 
   if (current_cpu != "arm" && is_chromeos) {
     sources += [ "filters/h264_bitstream_buffer_unittest.cc" ]
   }
 
   if (proprietary_codecs) {
     sources += [
       "cdm/cenc_utils_unittest.cc",
@@ skipping 302 matching lines @@
   fuzzer_test("media_mp4_avcc_parser_fuzzer") {
     sources = [
       "formats/mp4/mp4_avcc_parser_fuzzer.cc",
     ]
     deps = [
       ":media",
       "//base",
     ]
   }
 }