Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 2857953004: Fix for flaky WebViewTest.Shim_TestFindAPI_findupdate test on msan bots. (Closed)
Patch Set: Added TODO. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index 7a1cd01f62f295a6e281c15036f00fb76b298988..95dbdb2e54d490b75855676384f9bde64ab6edaf 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -2665,6 +2665,8 @@ function testFindAPI() {
document.body.appendChild(webview);
};
+// TODO(paulmeyer): Make sure this test is not still flaky. If it is, it is
+// likely because the search for "dog" compelted too quickly. crbug.com/710486.
function testFindAPI_findupdate() {
var webview = new WebView();
webview.src = testFindPage;
@@ -2683,8 +2685,8 @@ function testFindAPI_findupdate() {
if (e.canceled) {
canceledTest = true;
} else {
- embedder.test.assertEq(e.searchText, "dog");
- embedder.test.assertEq(e.numberOfMatches, 100);
+ embedder.test.assertEq(e.searchText, "cat");
+ embedder.test.assertEq(e.numberOfMatches, 10);
embedder.test.assertEq(e.activeMatchOrdinal, 1);
embedder.test.assertTrue(canceledTest);
embedder.test.succeed();
@@ -2692,8 +2694,8 @@ function testFindAPI_findupdate() {
}
});
webview.find("dog");
- webview.find("cat");
webview.find("dog");
+ webview.find("cat");
});
document.body.appendChild(webview);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698