Implement KernelNoSuchMethodResolver.

pkg/compiler/lib/src/js_backend/no_such_method_registry.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../common.dart';
 import '../common_elements.dart' show CommonElements;
 import '../common/names.dart' show Identifiers, Names, Selectors;
 import '../elements/elements.dart';
 import '../elements/entities.dart';
 import '../types/types.dart';
@@ skipping 52 matching lines @@
   /// The implementations that fall into category D1
   final Set<FunctionEntity> complexNoReturnImpls = new Set<FunctionEntity>();
 
   /// The implementations that fall into category D2
   final Set<FunctionEntity> complexReturningImpls = new Set<FunctionEntity>();
 
   /// The implementations that have not yet been categorized.
   final Set<FunctionEntity> _uncategorizedImpls = new Set<FunctionEntity>();
 
   final CommonElements _commonElements;
-  final NoSuchMethodResolver _resolver;
+  final NoSuchMethodResolver resolver;
 
-  NoSuchMethodRegistry(this._commonElements, this._resolver);
+  NoSuchMethodRegistry(this._commonElements, this.resolver);
 
   bool get hasThrowingNoSuchMethod => throwingImpls.isNotEmpty;
   bool get hasComplexNoSuchMethod => otherImpls.isNotEmpty;
 
   void registerNoSuchMethod(FunctionEntity noSuchMethodElement) {
     _uncategorizedImpls.add(noSuchMethodElement);
   }
 
   void onQueueEmpty() {
     _uncategorizedImpls.forEach(_categorizeImpl);
@@ skipping 11 matching lines @@
         complexNoReturnImpls.add(element);
       } else {
         complexReturningImpls.add(element);
       }
     });
   }
 
   /// Emits a diagnostic
   void emitDiagnostic(DiagnosticReporter reporter) {
     throwingImpls.forEach((e) {
-      if (!_resolver.hasForwardingSyntax(e)) {
+      if (!resolver.hasForwardingSyntax(e)) {
         reporter.reportHintMessage(e, MessageKind.DIRECTLY_THROWING_NSM);
       }
     });
     complexNoReturnImpls.forEach((e) {
-      if (!_resolver.hasForwardingSyntax(e)) {
+      if (!resolver.hasForwardingSyntax(e)) {
         reporter.reportHintMessage(e, MessageKind.COMPLEX_THROWING_NSM);
       }
     });
     complexReturningImpls.forEach((e) {
-      if (!_resolver.hasForwardingSyntax(e)) {
+      if (!resolver.hasForwardingSyntax(e)) {
         reporter.reportHintMessage(e, MessageKind.COMPLEX_RETURNING_NSM);
       }
     });
   }
 
   /// Returns [true] if the given element is a complex [noSuchMethod]
   /// implementation. An implementation is complex if it falls into
   /// category D, as described above.
   bool isComplex(FunctionEntity element) {
     assert(element.name == Identifiers.noSuchMethod_);
@@ skipping 14 matching lines @@
     if (notApplicableImpls.contains(element)) {
       return NsmCategory.NOT_APPLICABLE;
     }
     if (!Selectors.noSuchMethod_.signatureApplies(element)) {
       notApplicableImpls.add(element);
       return NsmCategory.NOT_APPLICABLE;
     }
     if (_commonElements.isDefaultNoSuchMethodImplementation(element)) {
       defaultImpls.add(element);
       return NsmCategory.DEFAULT;
-    } else if (_resolver.hasForwardingSyntax(element)) {
+    } else if (resolver.hasForwardingSyntax(element)) {
       // If the implementation is 'noSuchMethod(x) => super.noSuchMethod(x);'
       // then it is in the same category as the super call.
-      FunctionEntity superCall = _resolver.getSuperNoSuchMethod(element);
+      FunctionEntity superCall = resolver.getSuperNoSuchMethod(element);
       NsmCategory category = _categorizeImpl(superCall);
       switch (category) {
         case NsmCategory.DEFAULT:
           defaultImpls.add(element);
           break;
         case NsmCategory.THROWING:
           throwingImpls.add(element);
           break;
         case NsmCategory.OTHER:
           otherImpls.add(element);
           break;
         case NsmCategory.NOT_APPLICABLE:
           // If the super method is not applicable, the call is redirected to
           // `Object.noSuchMethod`.
           defaultImpls.add(element);
           category = NsmCategory.DEFAULT;
           break;
       }
       return category;
-    } else if (_resolver.hasThrowingSyntax(element)) {
+    } else if (resolver.hasThrowingSyntax(element)) {
       throwingImpls.add(element);
       return NsmCategory.THROWING;
     } else {
       otherImpls.add(element);
       return NsmCategory.OTHER;
     }
   }
 }
 
 enum NsmCategory {
@@ skipping 15 matching lines @@
   ///
   ///     noSuchMethod(i) => throw new Error();
   ///
   bool hasThrowingSyntax(FunctionEntity method);
 
   /// Returns the `noSuchMethod` that [method] overrides.
   FunctionEntity getSuperNoSuchMethod(FunctionEntity method);
 }
 
 /// AST-based implementation of [NoSuchMethodResolver].
 class NoSuchMethodResolverImpl implements NoSuchMethodResolver {

[Siggi Cherem (dart-lang), 2017/05/03 17:29:49]

move under resolution/* ?

[Johnni Winther, 2017/05/04 09:13:35]

Done.

   bool hasForwardingSyntax(MethodElement element) {
     // At this point we know that this is signature-compatible with
     // Object.noSuchMethod, but it may have more than one argument as long as
     // it only has one required argument.
     if (!element.hasResolvedAst) {
       // TODO(johnniwinther): Why do we see unresolved elements here?
       return false;
     }
     ResolvedAst resolvedAst = element.resolvedAst;
     if (resolvedAst.kind != ResolvedAstKind.PARSED) {
@@ skipping 59 matching lines @@
         return stmt.expression is Throw;
       }
     }
     return false;
   }
 
   MethodElement getSuperNoSuchMethod(MethodElement method) {
     return method.enclosingClass.lookupSuperByName(Names.noSuchMethod_);
   }
 }