Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Side by Side Diff: tools/perf/benchmarks/v8.py

Issue 2857923003: Re-enable v8.infinite_scroll_tbmv2 on Linux and disable it on Android. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « testing/buildbot/chromium.perf.fyi.json ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import os 4 import os
5 5
6 from core import path_util 6 from core import path_util
7 from core import perf_benchmark 7 from core import perf_benchmark
8 from page_sets import google_pages 8 from page_sets import google_pages
9 9
10 from benchmarks import v8_helper 10 from benchmarks import v8_helper
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 120
121 @classmethod 121 @classmethod
122 def ValueCanBeAddedPredicate(cls, value, _): 122 def ValueCanBeAddedPredicate(cls, value, _):
123 return ('v8' in value.name) or ('eqt' in value.name) 123 return ('v8' in value.name) or ('eqt' in value.name)
124 124
125 @classmethod 125 @classmethod
126 def ShouldTearDownStateAfterEachStoryRun(cls): 126 def ShouldTearDownStateAfterEachStoryRun(cls):
127 return True 127 return True
128 128
129 129
130 @benchmark.Disabled('linux') # crbug.com/715716 130 @benchmark.Disabled('android') # Android runs V8MobileInfiniteScroll.
131 @benchmark.Owner(emails=['ulan@chromium.org']) 131 @benchmark.Owner(emails=['ulan@chromium.org'])
132 class V8InfiniteScroll(_InfiniteScrollBenchmark): 132 class V8InfiniteScroll(_InfiniteScrollBenchmark):
133 """Measures V8 GC metrics and memory usage while scrolling the top web pages. 133 """Measures V8 GC metrics and memory usage while scrolling the top web pages.
134 http://www.chromium.org/developers/design-documents/rendering-benchmarks""" 134 http://www.chromium.org/developers/design-documents/rendering-benchmarks"""
135 135
136 page_set = page_sets.InfiniteScrollStorySet 136 page_set = page_sets.InfiniteScrollStorySet
137 137
138 @classmethod 138 @classmethod
139 def Name(cls): 139 def Name(cls):
140 return 'v8.infinite_scroll_tbmv2' 140 return 'v8.infinite_scroll_tbmv2'
141 141
142 @benchmark.Disabled('all') 142 @benchmark.Disabled('all')
143 @benchmark.Disabled('android') # Android runs V8MobileInfiniteScroll.
143 @benchmark.Owner(emails=['mvstaton@chromium.org']) 144 @benchmark.Owner(emails=['mvstaton@chromium.org'])
144 class V8InfiniteScrollTurbo(V8InfiniteScroll): 145 class V8InfiniteScrollTurbo(V8InfiniteScroll):
145 """Measures V8 GC metrics using Ignition+TurboFan.""" 146 """Measures V8 GC metrics using Ignition+TurboFan."""
146 147
147 def SetExtraBrowserOptions(self, options): 148 def SetExtraBrowserOptions(self, options):
148 super(V8InfiniteScrollTurbo, self).SetExtraBrowserOptions(options) 149 super(V8InfiniteScrollTurbo, self).SetExtraBrowserOptions(options)
149 v8_helper.EnableTurbo(options) 150 v8_helper.EnableTurbo(options)
150 151
151 @classmethod 152 @classmethod
152 def Name(cls): 153 def Name(cls):
153 return 'v8.infinite_scroll-turbo_tbmv2' 154 return 'v8.infinite_scroll-turbo_tbmv2'
154 155
155 156
156 @benchmark.Disabled('linux') # crbug.com/715716 157 @benchmark.Disabled('linux') # crbug.com/715716
158 @benchmark.Disabled('android') # Android runs V8MobileInfiniteScroll.
157 @benchmark.Owner(emails=['hablich@chromium.org']) 159 @benchmark.Owner(emails=['hablich@chromium.org'])
158 class V8InfiniteScrollClassic(V8InfiniteScroll): 160 class V8InfiniteScrollClassic(V8InfiniteScroll):
159 """Measures V8 GC metrics using the Classic pipeline.""" 161 """Measures V8 GC metrics using the Classic pipeline."""
160 162
161 def SetExtraBrowserOptions(self, options): 163 def SetExtraBrowserOptions(self, options):
162 super(V8InfiniteScrollClassic, self).SetExtraBrowserOptions(options) 164 super(V8InfiniteScrollClassic, self).SetExtraBrowserOptions(options)
163 v8_helper.EnableClassic(options) 165 v8_helper.EnableClassic(options)
164 166
165 @classmethod 167 @classmethod
166 def Name(cls): 168 def Name(cls):
(...skipping 136 matching lines...) Expand 10 before | Expand all | Expand 10 after
303 Designed to represent a mix between top websites and a set of pages that 305 Designed to represent a mix between top websites and a set of pages that
304 have unique V8 characteristics. 306 have unique V8 characteristics.
305 """ 307 """
306 308
307 @classmethod 309 @classmethod
308 def Name(cls): 310 def Name(cls):
309 return 'v8.runtime_stats.top_25' 311 return 'v8.runtime_stats.top_25'
310 312
311 def CreateStorySet(self, options): 313 def CreateStorySet(self, options):
312 return page_sets.V8Top25StorySet() 314 return page_sets.V8Top25StorySet()
OLDNEW
« no previous file with comments | « testing/buildbot/chromium.perf.fyi.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698