Issue 2857853003: Fix building of parameter descriptors from Kernel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2857853003: Fix building of parameter descriptors from Kernel (Closed)

Created:
3 years, 7 months ago by Kevin Millikin (Google)

Modified:
3 years, 7 months ago

Reviewers:
bkonyi

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Fix building of parameter descriptors from Kernel When building parameter descriptors from Kernel functions, the function's script is needed to get access to the string table. BUG= R=bkonyi@google.com Committed: https://github.com/dart-lang/sdk/commit/1e9143987a41526ae9e5b275e97b6083df75cec2

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -13 lines)			Patch
M	runtime/lib/mirrors.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download
M	runtime/vm/kernel_to_il.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/kernel_to_il.cc	View	2 chunks	+10 lines, -5 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

Kevin Millikin (Google)

3 years, 7 months ago (2017-05-02 23:57:07 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
1e9143987a41526ae9e5b275e97b6083df75cec2 (presubmit successful).