Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkPanel.js

Issue 2857833002: [Devtools] Move screenshots to below filter bar in network (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org> 3 * Copyright (C) 2008, 2009 Anthony Ricaud <rik@webkit.org>
4 * Copyright (C) 2011 Google Inc. All rights reserved. 4 * Copyright (C) 2011 Google Inc. All rights reserved.
5 * 5 *
6 * Redistribution and use in source and binary forms, with or without 6 * Redistribution and use in source and binary forms, with or without
7 * modification, are permitted provided that the following conditions 7 * modification, are permitted provided that the following conditions
8 * are met: 8 * are met:
9 * 9 *
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 301 matching lines...) Expand 10 before | Expand all | Expand 10 after
312 } 312 }
313 313
314 _toggleRecordFilmStrip() { 314 _toggleRecordFilmStrip() {
315 var toggled = this._networkRecordFilmStripSetting.get(); 315 var toggled = this._networkRecordFilmStripSetting.get();
316 if (toggled && !this._filmStripRecorder) { 316 if (toggled && !this._filmStripRecorder) {
317 this._filmStripView = new PerfUI.FilmStripView(); 317 this._filmStripView = new PerfUI.FilmStripView();
318 this._filmStripView.setMode(PerfUI.FilmStripView.Modes.FrameBased); 318 this._filmStripView.setMode(PerfUI.FilmStripView.Modes.FrameBased);
319 this._filmStripView.element.classList.add('network-film-strip'); 319 this._filmStripView.element.classList.add('network-film-strip');
320 this._filmStripRecorder = 320 this._filmStripRecorder =
321 new Network.NetworkPanel.FilmStripRecorder(this._networkLogView.timeCa lculator(), this._filmStripView); 321 new Network.NetworkPanel.FilmStripRecorder(this._networkLogView.timeCa lculator(), this._filmStripView);
322 this._filmStripView.show(this.element, this.element.firstElementChild); 322 this._filmStripView.show(this.element, this._overviewPane.element);
323 this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameSele cted, this._onFilmFrameSelected, this); 323 this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameSele cted, this._onFilmFrameSelected, this);
324 this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameEnte r, this._onFilmFrameEnter, this); 324 this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameEnte r, this._onFilmFrameEnter, this);
325 this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameExit , this._onFilmFrameExit, this); 325 this._filmStripView.addEventListener(PerfUI.FilmStripView.Events.FrameExit , this._onFilmFrameExit, this);
326 this._resetFilmStripView(); 326 this._resetFilmStripView();
327 } 327 }
328 328
329 if (!toggled && this._filmStripRecorder) { 329 if (!toggled && this._filmStripRecorder) {
330 this._filmStripView.detach(); 330 this._filmStripView.detach();
331 this._filmStripView = null; 331 this._filmStripView = null;
332 this._filmStripRecorder = null; 332 this._filmStripRecorder = null;
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
725 * @param {string} actionId 725 * @param {string} actionId
726 * @return {boolean} 726 * @return {boolean}
727 */ 727 */
728 handleAction(context, actionId) { 728 handleAction(context, actionId) {
729 var panel = UI.context.flavor(Network.NetworkPanel); 729 var panel = UI.context.flavor(Network.NetworkPanel);
730 console.assert(panel && panel instanceof Network.NetworkPanel); 730 console.assert(panel && panel instanceof Network.NetworkPanel);
731 panel._toggleRecording(); 731 panel._toggleRecording();
732 return true; 732 return true;
733 } 733 }
734 }; 734 };
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698