Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: src/heap/incremental-marking.h

Issue 2857743002: [heap] Use atomic marking operations in incremental marking if (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | src/heap/incremental-marking.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/incremental-marking.h
diff --git a/src/heap/incremental-marking.h b/src/heap/incremental-marking.h
index b827f6aba17fb90411ac0c2b3911899c97475214..3b490c84eb294db9623230a3fd236e19ec395d91 100644
--- a/src/heap/incremental-marking.h
+++ b/src/heap/incremental-marking.h
@@ -161,6 +161,12 @@ class V8_EXPORT_PRIVATE IncrementalMarking {
static const intptr_t kActivationThreshold = 0;
#endif
+#ifdef V8_CONCURRENT_MARKING
+ static const MarkBit::AccessMode kAtomicity = MarkBit::AccessMode::ATOMIC;
Hannes Payer (out of office) 2017/05/03 10:08:53 I am not sure if this is the right mechanism here.
ulan 2017/05/03 12:09:30 As discussed offline, in future we will have two I
+#else
+ static const MarkBit::AccessMode kAtomicity = MarkBit::AccessMode::NON_ATOMIC;
+#endif
+
void FinalizeSweeping();
size_t Step(size_t bytes_to_process, CompletionAction action,
« no previous file with comments | « no previous file | src/heap/incremental-marking.cc » ('j') | src/heap/incremental-marking.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698