Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 285763004: Cleanup android specific code of //chrome/browser/history (Closed)

Created:
6 years, 7 months ago by sdefresne
Modified:
6 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Cleanup android specific code of //chrome/browser/history Forward-declare AndroidHistoryProviderService in history_service.h instead of including android_history_provider_service.h since the type is only used for a friendship declaration. BUG=371820 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272464

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/history/history_service.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
sdefresne
Please have a look.
6 years, 7 months ago (2014-05-14 17:06:03 UTC) #1
sky
LGTM
6 years, 7 months ago (2014-05-14 19:07:26 UTC) #2
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-16 14:30:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/285763004/40001
6 years, 7 months ago (2014-05-16 14:32:06 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-16 16:24:33 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-16 17:27:22 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chromeos_rel/builds/27878)
6 years, 7 months ago (2014-05-16 17:27:22 UTC) #7
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 7 months ago (2014-05-23 08:51:00 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sdefresne@chromium.org/285763004/40001
6 years, 7 months ago (2014-05-23 08:52:48 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 10:25:35 UTC) #10
Message was sent while issue was closed.
Change committed as 272464

Powered by Google App Engine
This is Rietveld 408576698