Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 285763003: Add warning about GOPATH to bug_chomper/run_server.sh (Closed)

Created:
6 years, 7 months ago by borenet
Modified:
6 years, 7 months ago
Reviewers:
scroggo
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add warning about GOPATH to bug_chomper/run_server.sh BUG=skia:2551 Committed: http://code.google.com/p/skia/source/detail?r=14732

Patch Set 1 #

Patch Set 2 : Add goauth2 dependency #

Total comments: 2

Patch Set 3 : 80 chars #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M tools/bug_chomper/run_server.sh View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
borenet
6 years, 7 months ago (2014-05-14 14:45:42 UTC) #1
scroggo
lgtm https://codereview.chromium.org/285763003/diff/20001/tools/bug_chomper/run_server.sh File tools/bug_chomper/run_server.sh (right): https://codereview.chromium.org/285763003/diff/20001/tools/bug_chomper/run_server.sh#newcode7 tools/bug_chomper/run_server.sh:7: echo "GOPATH environment variable is not set. Please ...
6 years, 7 months ago (2014-05-14 15:04:49 UTC) #2
borenet
Uploaded patch set 3. https://codereview.chromium.org/285763003/diff/20001/tools/bug_chomper/run_server.sh File tools/bug_chomper/run_server.sh (right): https://codereview.chromium.org/285763003/diff/20001/tools/bug_chomper/run_server.sh#newcode7 tools/bug_chomper/run_server.sh:7: echo "GOPATH environment variable is ...
6 years, 7 months ago (2014-05-14 15:35:12 UTC) #3
borenet
The CQ bit was checked by borenet@google.com
6 years, 7 months ago (2014-05-14 15:35:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/285763003/40001
6 years, 7 months ago (2014-05-14 15:35:29 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-14 15:42:15 UTC) #6
Message was sent while issue was closed.
Change committed as 14732

Powered by Google App Engine
This is Rietveld 408576698