Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Issue 2857583007: [RLS] Don't add to ScrollableAreaSet if the size is zero (Closed)
Patch Set: address review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 4 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
5 * 5 *
6 * Other contributors: 6 * Other contributors:
7 * Robert O'Callahan <roc+@cs.cmu.edu> 7 * Robert O'Callahan <roc+@cs.cmu.edu>
8 * David Baron <dbaron@fas.harvard.edu> 8 * David Baron <dbaron@fas.harvard.edu>
9 * Christian Biesinger <cbiesinger@web.de> 9 * Christian Biesinger <cbiesinger@web.de>
10 * Randall Jesup <rjesup@wgate.com> 10 * Randall Jesup <rjesup@wgate.com>
(...skipping 493 matching lines...) Expand 10 before | Expand all | Expand 10 after
504 504
505 uint64_t Id() const; 505 uint64_t Id() const;
506 506
507 DECLARE_VIRTUAL_TRACE(); 507 DECLARE_VIRTUAL_TRACE();
508 508
509 private: 509 private:
510 explicit PaintLayerScrollableArea(PaintLayer&); 510 explicit PaintLayerScrollableArea(PaintLayer&);
511 511
512 bool HasHorizontalOverflow() const; 512 bool HasHorizontalOverflow() const;
513 bool HasVerticalOverflow() const; 513 bool HasVerticalOverflow() const;
514 bool HasScrollableHorizontalOverflow() const;
515 bool HasScrollableVerticalOverflow() const;
516 bool VisualViewportSuppliesScrollbars() const; 514 bool VisualViewportSuppliesScrollbars() const;
517 515
518 bool NeedsScrollbarReconstruction() const; 516 bool NeedsScrollbarReconstruction() const;
519 517
520 void UpdateScrollOrigin(); 518 void UpdateScrollOrigin();
521 void UpdateScrollDimensions(); 519 void UpdateScrollDimensions();
522 void UpdateScrollbarEnabledState(); 520 void UpdateScrollbarEnabledState();
523 521
524 void UpdateScrollOffset(const ScrollOffset&, ScrollType) override; 522 void UpdateScrollOffset(const ScrollOffset&, ScrollType) override;
525 523
(...skipping 11 matching lines...) Expand all
537 bool SetHasHorizontalScrollbar(bool has_scrollbar); 535 bool SetHasHorizontalScrollbar(bool has_scrollbar);
538 bool SetHasVerticalScrollbar(bool has_scrollbar); 536 bool SetHasVerticalScrollbar(bool has_scrollbar);
539 537
540 void UpdateScrollCornerStyle(); 538 void UpdateScrollCornerStyle();
541 LayoutSize MinimumSizeForResizing(float zoom_factor); 539 LayoutSize MinimumSizeForResizing(float zoom_factor);
542 540
543 // See comments on isPointInResizeControl. 541 // See comments on isPointInResizeControl.
544 void UpdateResizerAreaSet(); 542 void UpdateResizerAreaSet();
545 void UpdateResizerStyle(); 543 void UpdateResizerStyle();
546 544
547 void UpdateScrollableAreaSet(bool has_overflow); 545 void UpdateScrollableAreaSet();
548 546
549 void UpdateCompositingLayersAfterScroll(); 547 void UpdateCompositingLayersAfterScroll();
550 548
551 ScrollingCoordinator* GetScrollingCoordinator() const; 549 ScrollingCoordinator* GetScrollingCoordinator() const;
552 550
553 PaintLayerScrollableAreaRareData* RareData() { return rare_data_.get(); } 551 PaintLayerScrollableAreaRareData* RareData() { return rare_data_.get(); }
554 552
555 PaintLayerScrollableAreaRareData& EnsureRareData() { 553 PaintLayerScrollableAreaRareData& EnsureRareData() {
556 if (!rare_data_) 554 if (!rare_data_)
557 rare_data_ = WTF::MakeUnique<PaintLayerScrollableAreaRareData>(); 555 rare_data_ = WTF::MakeUnique<PaintLayerScrollableAreaRareData>();
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
620 618
621 DEFINE_TYPE_CASTS(PaintLayerScrollableArea, 619 DEFINE_TYPE_CASTS(PaintLayerScrollableArea,
622 ScrollableArea, 620 ScrollableArea,
623 scrollableArea, 621 scrollableArea,
624 scrollableArea->IsPaintLayerScrollableArea(), 622 scrollableArea->IsPaintLayerScrollableArea(),
625 scrollableArea.IsPaintLayerScrollableArea()); 623 scrollableArea.IsPaintLayerScrollableArea());
626 624
627 } // namespace blink 625 } // namespace blink
628 626
629 #endif // LayerScrollableArea_h 627 #endif // LayerScrollableArea_h
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698