base/trace_event/heap_profiler_stack_frame_deduplicator.cc - Issue 2857543002: tracing: Simplify TraceEventMemoryOverhead, use an enum insted of a map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/heap_profiler_stack_frame_deduplicator.cc

Issue 2857543002: tracing: Simplify TraceEventMemoryOverhead, use an enum insted of a map (Closed)

Patch Set: Fix compiler issues + omit empty values Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/heap_profiler_stack_frame_deduplicator.cc

diff --git a/base/trace_event/heap_profiler_stack_frame_deduplicator.cc b/base/trace_event/heap_profiler_stack_frame_deduplicator.cc

index fc5da0d1dde9ed15498e1d03574d737c5f004460..efae0ca7eb2d8d7fb8aaa9b5fec8dc7864e40ab9 100644

--- a/base/trace_event/heap_profiler_stack_frame_deduplicator.cc

+++ b/base/trace_event/heap_profiler_stack_frame_deduplicator.cc

@@ -123,7 +123,7 @@ void StackFrameDeduplicator::EstimateTraceMemoryOverhead(

TraceEventMemoryOverhead* overhead) {

size_t memory_usage =

EstimateMemoryUsage(frames_) + EstimateMemoryUsage(roots_);

- overhead->Add("StackFrameDeduplicator",

+ overhead->Add(TraceEventMemoryOverhead::kHeapProfilerStackFrameDeduplicator,

sizeof(StackFrameDeduplicator) + memory_usage);

}