Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 2857513002: Revert "VM: [Kernel] elide parent context setup if it's empty" (Closed)

Created:
3 years, 7 months ago by karlklose
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "VM: [Kernel] elide parent context setup if it's empty" This reverts commit 7a463aef22eb35ce139b0b3c3cc9b0f993a5c0d4. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/5389b1114ebe480ac82e5e98e7bd573fa63b832e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -15 lines) Patch
M runtime/vm/kernel_to_il.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/kernel_to_il.cc View 1 chunk +5 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
karlklose
The following tests were crashing on the vm-kernel-linux-debug-x64-be buildbot: python tools/test.py -cdartk -t120 --builder-tag no_ipv6 ...
3 years, 7 months ago (2017-05-02 09:35:34 UTC) #1
Vyacheslav Egorov (Google)
lgtm
3 years, 7 months ago (2017-05-02 09:37:22 UTC) #2
karlklose
Committed patchset #1 (id:1) manually as 5389b1114ebe480ac82e5e98e7bd573fa63b832e (presubmit successful).
3 years, 7 months ago (2017-05-02 09:56:48 UTC) #4
karlklose
3 years, 7 months ago (2017-05-03 07:32:27 UTC) #5
Message was sent while issue was closed.
On 2017/05/02 09:35:34, karlklose wrote:
> The following tests were crashing on the vm-kernel-linux-debug-x64-be
buildbot:
> 
> python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options
> --no-enable-malloc-hooks
>
co19/Language/Expressions/Identifier_Reference/evaluation_variable_or_parameter_t04
> python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options
> --no-enable-malloc-hooks corelib/hash_map2_test
> python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options
> --no-enable-malloc-hooks corelib/iterable_fold_test
> python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options
> --no-enable-malloc-hooks corelib/iterable_reduce_test
> python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options
> --no-enable-malloc-hooks language/modulo_test
> python tools/test.py -cdartk -t120 --builder-tag no_ipv6 --vm-options
> --no-enable-malloc-hooks lib/async/stream_event_transformed_test

This seems also to have been caused by the reverted commit:
https://github.com/dart-lang/sdk/issues/29513

Powered by Google App Engine
This is Rietveld 408576698