Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js

Issue 2857453002: DevTools: support resolving a UILocation to multiple raw script locations (Closed)
Patch Set: get rid of uniqueScriptId() Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
diff --git a/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js b/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
index 0d0607674df2ffb6c17fb202cc2772e71f79b673..a41b4060e978238353d83eee1aad89d3252ab0c9 100644
--- a/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
+++ b/third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js
@@ -84,15 +84,18 @@ Bindings.DefaultScriptMapping = class {
* @param {!Workspace.UISourceCode} uiSourceCode
* @param {number} lineNumber
* @param {number} columnNumber
- * @return {?SDK.DebuggerModel.Location}
+ * @return {!Array<!SDK.DebuggerModel.Location>}
*/
- uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber) {
+ uiLocationToRawLocations(uiSourceCode, lineNumber, columnNumber) {
var script = uiSourceCode[Bindings.DefaultScriptMapping._scriptSymbol];
+ var location;
if (script.isInlineScriptWithSourceURL()) {
- return this._debuggerModel.createRawLocation(
+ location = this._debuggerModel.createRawLocation(
script, lineNumber + script.lineOffset, lineNumber ? columnNumber : columnNumber + script.columnOffset);
+ } else {
+ location = this._debuggerModel.createRawLocation(script, lineNumber, columnNumber);
}
- return this._debuggerModel.createRawLocation(script, lineNumber, columnNumber);
+ return location ? [location] : [];
}
/**

Powered by Google App Engine
This is Rietveld 408576698