third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html - Issue 2857453002: DevTools: support resolving a UILocation to multiple raw script locations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html

Issue 2857453002: DevTools: support resolving a UILocation to multiple raw script locations (Closed)

Patch Set: Review comments addressed Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/text-source-map.html ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.js » ('j') | third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html

index c896fa097cb9e96ac4fa37940f65e173f2cc813b..2c97c3a27a6857a5f1d6efd6328e27286f35b516 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager.html

@@ -183,9 +183,9 @@ function test()

return InspectorTest.uiSourceCodes[rawLocation.scriptId].uiLocation(rawLocation.lineNumber + 10, 0);

- uiLocationToRawLocation: function(uiSourceCode, lineNumber)

+ uiLocationToRawLocations: function(uiSourceCode, lineNumber)

{

- return new SDK.DebuggerModel.Location(mockTarget.debuggerModel, uiSourceCode.url(), lineNumber - 10, 0);

+ return [new SDK.DebuggerModel.Location(mockTarget.debuggerModel, uiSourceCode.url(), lineNumber - 10, 0)];

isIdentity: function()

@@ -255,9 +255,9 @@ function test()

return uiSourceCodeB.uiLocation(rawLocation.lineNumber + 10, 0);

- uiLocationToRawLocation: function(uiSourceCode, lineNumber)

+ uiLocationToRawLocations: function(uiSourceCode, lineNumber)

{

- return new SDK.DebuggerModel.Location(mockTarget.debuggerModel, uiSourceCodeA.url(), lineNumber - 10, 0);

+ return [new SDK.DebuggerModel.Location(mockTarget.debuggerModel, uiSourceCodeA.url(), lineNumber - 10, 0)];

isIdentity: function()