DevTools: support resolving a UILocation to multiple raw script locations

third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 248 matching lines @@
     var columnBreakpoints = lineBreakpoints ? lineBreakpoints.get(columnNumber) : null;
     return columnBreakpoints ? columnBreakpoints[0] : null;
   }
 
   /**
    * @param {!Workspace.UISourceCode} uiSourceCode
    * @param {!TextUtils.TextRange} textRange
    * @return {!Promise<!Array<!Workspace.UILocation>>}
    */
   possibleBreakpoints(uiSourceCode, textRange) {
-    var startLocation = Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(
-        uiSourceCode, textRange.startLine, textRange.startColumn);
-    var endLocation =
-        Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiSourceCode, textRange.endLine, textRange.endColumn);
+    var startLocation = Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations(
+        uiSourceCode, textRange.startLine, textRange.startColumn)[0];

[dgozman, 2017/05/02 19:47:41]

This is suspicious. What if there are multiple and the order is different? We
will fail check in line 273.

+    var endLocation = Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations(
+        uiSourceCode, textRange.endLine, textRange.endColumn)[0];
     if (!startLocation || !endLocation || startLocation.debuggerModel !== endLocation.debuggerModel)
       return Promise.resolve([]);
 
     return startLocation.debuggerModel
         .getPossibleBreakpoints(startLocation, endLocation, /* restrictToFunction */ false)
         .then(toUILocations.bind(this));
 
     /**
      * @this {!Bindings.BreakpointManager}
      * @param {!Array<!SDK.DebuggerModel.BreakLocation>} locations
@@ skipping 519 matching lines @@
       callback();
       return;
     }
 
     var uiSourceCode = this._breakpoint.uiSourceCode();
     var lineNumber = this._breakpoint._lineNumber;
     var columnNumber = this._breakpoint._columnNumber;
     var condition = this._breakpoint.condition();
 
     var debuggerLocation = uiSourceCode &&
-        Bindings.debuggerWorkspaceBinding.uiLocationToRawLocation(uiSourceCode, lineNumber, columnNumber);
+        Bindings.debuggerWorkspaceBinding.uiLocationToRawLocations(uiSourceCode, lineNumber, columnNumber)[0];
     var newState;
     if (this._breakpoint._isRemoved || !this._breakpoint.enabled() || this._scriptDiverged()) {
       newState = null;
     } else if (debuggerLocation) {
       var script = debuggerLocation.script();
       if (script.sourceURL) {
         newState = new Bindings.BreakpointManager.Breakpoint.State(
             script.sourceURL, null, debuggerLocation.lineNumber, debuggerLocation.columnNumber, condition);
       } else {
         newState = new Bindings.BreakpointManager.Breakpoint.State(
@@ skipping 257 matching lines @@
     this.url = breakpoint._url;
     this.lineNumber = breakpoint.lineNumber();
     this.columnNumber = breakpoint.columnNumber();
     this.condition = breakpoint.condition();
     this.enabled = breakpoint.enabled();
   }
 };
 
 /** @type {!Bindings.BreakpointManager} */
 Bindings.breakpointManager;