Issue 285743004: Redundant call to closeMediaSource and unnecessary condition in createMediaPlayer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 285743004: Redundant call to closeMediaSource and unnecessary condition in createMediaPlayer (Closed)

Created:
6 years, 7 months ago by Srirama

Modified:
6 years, 7 months ago

Reviewers:
acolwell GONE FROM CHROMIUM, philipj_slow

CC:
blink-reviews, blink-reviews-html_chromium.org, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Redundant call to closeMediaSource and unnecessary condition in createMediaPlayer BUG=373208 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174070

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	Source/core/html/HTMLMediaElement.cpp	View		2 chunks	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Srirama

While going through the code I came across some unnecessary code. 1) In prepareForLoad() function ...

6 years, 7 months ago (2014-05-14 13:32:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/srirama.m@samsung.com/285743004/1

6 years, 7 months ago (2014-05-15 04:54:25 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-15 06:06:59 UTC) #5

Message was sent while issue was closed.

Change committed as 174070

Expand Messages | Collapse Messages