Handle more constants in Constantifier

Handle more constants in Constantifier

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/85f6d6987272f36beef79cbd7d3537a0db65a57e

[Johnni Winther, 2017-05-04 10:37:58]

johnniwinther@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2017-05-04 19:13:40]

lgtm

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_adapter.dart (right):

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:18: import
'../resolution/operators.dart';
minor: it would be good to move the operators file elsewhere if we intend to
continue using it in the future

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:551: DartType type /* =
elementAdapter.getFunctionType(function)*/;
uncomment?

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:640: ConstantExpression
receiver = visit(node.receiver);
do we need to check that receiver is String?

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:645: ConstantExpression
visitMethodInvocation(ir.MethodInvocation node) {
minor: it might be worth adding a 1-line comment here explaining that method
invocations are not constants, but some unary and binary operators are (which
kernel encodes as method invocations)

[Johnni Winther, 2017-05-05 08:17:20]

Description was changed from

==========
Handle more constants in Constantifier
==========

to

==========
Handle more constants in Constantifier

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/85f6d6987272f36beef79cbd7d3537a0db65a57e
==========

[Johnni Winther, 2017-05-05 08:17:22]

Committed patchset #2 (id:20001) manually as
85f6d6987272f36beef79cbd7d3537a0db65a57e (presubmit successful).

[Johnni Winther, 2017-05-05 08:17:26]

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
File pkg/compiler/lib/src/kernel/element_adapter.dart (right):

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:18: import
'../resolution/operators.dart';
On 2017/05/04 19:13:40, Siggi Cherem (dart-lang) wrote:
> minor: it would be good to move the operators file elsewhere if we intend to
> continue using it in the future

Will do in a follow-up.

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:551: DartType type /* =
elementAdapter.getFunctionType(function)*/;
On 2017/05/04 19:13:40, Siggi Cherem (dart-lang) wrote:
> uncomment?

Done.

https://codereview.chromium.org/2857373002/diff/1/pkg/compiler/lib/src/kernel...
pkg/compiler/lib/src/kernel/element_adapter.dart:640: ConstantExpression
receiver = visit(node.receiver);
On 2017/05/04 19:13:39, Siggi Cherem (dart-lang) wrote:
> do we need to check that receiver is String?

We can't tell. Only when you evaluate can you determine the type. For instance

const value = (const bool.fromEnvironment('foo') ? 'foo' : 0).length;