Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(949)

Unified Diff: rlz/lib/rlz_lib.h

Issue 2857343004: Add rlz_utils as a new build target to rlz/ (Closed)
Patch Set: Move RLZ_LIB_API to shared rlz_enums.h Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: rlz/lib/rlz_lib.h
diff --git a/rlz/lib/rlz_lib.h b/rlz/lib/rlz_lib.h
index 0f98c4c1048cdad87d93afa314b2cfad2d8ffc59..1dfbf73a1808346b371892691235d165ff27ae17 100644
--- a/rlz/lib/rlz_lib.h
+++ b/rlz/lib/rlz_lib.h
@@ -20,12 +20,6 @@
#include "rlz/lib/rlz_enums.h"
-#if defined(OS_WIN)
-#define RLZ_LIB_API __cdecl
-#else
-#define RLZ_LIB_API
-#endif
-
// Define one of
// + RLZ_NETWORK_IMPLEMENTATION_WIN_INET: Uses win inet to send financial pings.
// + RLZ_NETWORK_IMPLEMENTATION_CHROME_NET: Uses chrome's network stack to send
@@ -77,9 +71,6 @@ const size_t kMaxRlzLength = 64;
const size_t kMaxDccLength = 128;
// The maximum length of a CGI string in bytes.
const size_t kMaxCgiLength = 2048;
-// The maximum length of a ping response we will parse in bytes. If the response
-// is bigger, please break it up into separate calls.
-const size_t kMaxPingResponseLength = 0x4000; // 16K
#if defined(RLZ_NETWORK_IMPLEMENTATION_CHROME_NET)
// Set the URLRequestContextGetter used by SendFinancialPing(). The IO message
@@ -177,15 +168,6 @@ bool RLZ_LIB_API FormFinancialPingRequest(Product product,
char* request,
size_t request_buffer_size);
-// Checks if a ping response is valid - ie. it has a checksum line which
-// is the CRC-32 checksum of the message uptil the checksum. If
-// checksum_idx is not NULL, it will get the index of the checksum, i.e. -
-// the effective end of the message.
-// Access: No restrictions.
-bool RLZ_LIB_API IsPingResponseValid(const char* response,
- int* checksum_idx);
-
-
// Complex helpers built on top of other functions.
// Parses the responses from the financial server and updates product state
« rlz/lib/rlz_enums.h ('K') | « rlz/lib/rlz_enums.h ('k') | rlz/lib/rlz_lib.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698