Add rlz_utils as a new build target to rlz/

rlz/lib/rlz_enums.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef RLZ_LIB_RLZ_ENUMS_H_
 #define RLZ_LIB_RLZ_ENUMS_H_
 
+#if defined(OS_WIN)
+#define RLZ_LIB_API __cdecl
+#else
+#define RLZ_LIB_API
+#endif
+

[Roger Tawa OOO till Jul 10th, 2017/05/05 15:31:29]

I see why you did this, but it is sub optimal.  This file does not need
RLZ_LIB_API, and the files that do (rlz_lib.h and net_response_check.h) depend
on including this file.

I think I'd rather see this duplicated in both other headers than included here,
like patchset 5.  (I'm not sure why the rlz api needs to be __cdecl).  If you
really don't want duplication, then let's create a new header file.

[Yusuf, 2017/05/05 17:14:58]

Got it.

I had them duplicated, then win_clang builder got upset about the duplication. I
will add a new header file.

 namespace rlz_lib {
 
 // An Access Point offers a way to search using Google.
 enum AccessPoint {
   NO_ACCESS_POINT = 0,
 
   // Access points on Windows PCs.
   IE_DEFAULT_SEARCH,  // The IE7+ chrome search box next to the address bar.
   IE_HOME_PAGE,       // Search box on IE 5+ primary home page when Google.
   IETB_SEARCH_BOX,    // IE Toolbar v4+ search box.
@@ skipping 105 matching lines @@
 // Events that note Product and Access Point modifications.
 enum Event {
   INVALID_EVENT = 0,
   INSTALL = 1,    // Access Point added to the system.
   SET_TO_GOOGLE,  // Point set from non-Google provider to Google.
   FIRST_SEARCH,   // First search from point since INSTALL
   REPORT_RLS,     // Report old system "RLS" financial value for this point.
   // New Events should be added here without changing existing enums,
   // before LAST_EVENT.
   ACTIVATE,       // Product being used for a period of time.
   LAST_EVENT

[Roger Tawa OOO till Jul 10th, 2017/05/05 15:31:29]

Do you plan on adding new events in a follow up CL?

[Yusuf, 2017/05/05 17:14:58]

I may. Not sure on that part since they will be given by the rlz team to us. I
think we may end up overriding some of these with a new custom brand.

 };
 
 }  // namespace rlz_lib
 
 #endif  // RLZ_LIB_RLZ_ENUMS_H_