pkg/compiler/lib/src/ssa/kernel_impact.dart - Issue 2857333003: Handle const Symbol(...) in closed_world2_test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/kernel_impact.dart

Issue 2857333003: Handle const Symbol(...) in closed_world2_test (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/kernel_impact.dart

diff --git a/pkg/compiler/lib/src/ssa/kernel_impact.dart b/pkg/compiler/lib/src/ssa/kernel_impact.dart

index a564ca5e7df1974f4b12bc61997baefc6cea766c..a697b5dd611c2a34d59bf3689df002d64b1b01c7 100644

--- a/pkg/compiler/lib/src/ssa/kernel_impact.dart

+++ b/pkg/compiler/lib/src/ssa/kernel_impact.dart

@@ -270,6 +270,9 @@ class KernelImpactBuilder extends ir.Visitor {

{bool isConst: false}) {

_visitArguments(node.arguments);

ConstructorEntity constructor = elementAdapter.getConstructor(target);

+ if (commonElements.isSymbolConstructor(constructor)) {

+ impactBuilder.registerFeature(Feature.SYMBOL_CONSTRUCTOR);

+ }

InterfaceType type = elementAdapter.createInterfaceType(

target.enclosingClass, node.arguments.types);

CallStructure callStructure =