Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2857333003: Handle const Symbol(...) in closed_world2_test (Closed)

Created:
3 years, 7 months ago by Johnni Winther
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 7 months ago (2017-05-04 11:11:12 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 7 months ago (2017-05-04 19:16:42 UTC) #3
Johnni Winther
3 years, 7 months ago (2017-05-05 08:22:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
36af30ff4222b64d0fbcdcbc7aed59c71d6d8554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698