Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4480)

Unified Diff: chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc

Issue 2857333002: [TTS] Write initial Tap-features to Ranker. (Closed)
Patch Set: Added logging of the CS-model URL and updated console-logging output. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
diff --git a/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc b/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
new file mode 100644
index 0000000000000000000000000000000000000000..d26b2ab2798096a113af466af2d9f01889c14163
--- /dev/null
+++ b/chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc
@@ -0,0 +1,96 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include <chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.h>
+
+#include "base/android/jni_string.h"
+#include "base/android/scoped_java_ref.h"
+#include "base/metrics/metrics_hashes.h"
+#include "chrome/browser/browser_process.h"
+#include "components/keyed_service/core/keyed_service.h"
+#include "components/ukm/ukm_entry_builder.h"
+#include "components/ukm/ukm_service.h"
+#include "jni/ContextualSearchRankerLoggerImpl_jni.h"
+
+ContextualSearchRankerLoggerImpl::ContextualSearchRankerLoggerImpl(
+ JNIEnv* env,
+ jobject obj) {
+ java_object_.Reset(env, obj);
+}
+
+ContextualSearchRankerLoggerImpl::~ContextualSearchRankerLoggerImpl() {
+ java_object_ = nullptr;
+}
+
+void ContextualSearchRankerLoggerImpl::SetUkmServiceAndUrls(
+ JNIEnv* env,
+ jobject obj,
+ const base::android::JavaParamRef<jstring>& j_base_page_url,
+ const base::android::JavaParamRef<jstring>& j_model_url) {
+ GURL page_url =
+ GURL(base::android::ConvertJavaStringToUTF8(env, j_base_page_url));
+ std::string model_url =
+ base::android::ConvertJavaStringToUTF8(env, j_model_url);
+ ukm::UkmService* ukm_service = g_browser_process->ukm_service();
+ SetUkmService(ukm_service, page_url);
+ // TODO(donnd): Is this a reasonable way to handle the model URL?
+ builder_->AddMetric("ContextualSearchModelUrl",
+ base::HashMetricName(model_url));
Theresa 2017/05/12 01:02:25 Should we change model URL to model name or someth
Donn Denman 2017/05/12 23:08:55 Good suggestion -- I think I like "model selector"
+}
+
+void ContextualSearchRankerLoggerImpl::SetUkmService(
+ ukm::UkmService* ukm_service,
+ const GURL& page_url) {
+ ukm_service_ = ukm_service;
+ DVLOG(0) << "ctxs Setting up UKM for url: " << page_url.spec();
+ source_id_ = ukm_service_->GetNewSourceID();
+ ukm_service_->UpdateSourceURL(source_id_, page_url);
+ builder_ = ukm_service_->GetEntryBuilder(source_id_, "ContextualSearch");
+}
+
+void ContextualSearchRankerLoggerImpl::LogLong(
+ JNIEnv* env,
+ jobject obj,
+ const base::android::JavaParamRef<jstring>& j_feature,
+ jlong j_long) {
+ std::string feature = base::android::ConvertJavaStringToUTF8(env, j_feature);
+ DVLOG(0) << "Logging feature " << feature << " value " << j_long;
+ builder_->AddMetric(feature.c_str(), j_long);
+}
+
+void ContextualSearchRankerLoggerImpl::LogString(
+ JNIEnv* env,
+ jobject obj,
+ const base::android::JavaParamRef<jstring>& j_feature,
+ const base::android::JavaParamRef<jstring>& j_string) {
+ std::string feature = base::android::ConvertJavaStringToUTF8(env, j_feature);
+ std::string string = base::android::ConvertJavaStringToUTF8(env, j_string);
+ DVLOG(0) << "Logging feature " << feature << " value " << string;
+ builder_->AddMetric(feature.c_str(), base::HashMetricName(string));
+}
+
+void ContextualSearchRankerLoggerImpl::WriteLogAndReset(JNIEnv* env,
+ jobject obj) {
+ // Set up another builder for the next record (in case it's needed).
+ builder_ = ukm_service_->GetEntryBuilder(source_id_, "ContextualSearch");
+ DVLOG(0) << "Creating a new record builder";
Theresa 2017/05/12 01:02:25 We should probably remove these before landing sin
Donn Denman 2017/05/12 23:08:55 I think they're OK since they're debug-only, and t
+}
+
+// Java wrapper boilerplate
+
+void ContextualSearchRankerLoggerImpl::Destroy(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj) {
+ delete this;
+}
+
+bool RegisterContextualSearchRankerLoggerImpl(JNIEnv* env) {
+ return RegisterNativesImpl(env);
+}
+
+jlong Init(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj) {
+ ContextualSearchRankerLoggerImpl* ranker_logger_impl =
+ new ContextualSearchRankerLoggerImpl(env, obj);
+ return reinterpret_cast<intptr_t>(ranker_logger_impl);
+}

Powered by Google App Engine
This is Rietveld 408576698