[TTS] Write initial Tap-features to Ranker.

chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java

Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
index 7495c0fd33331599fe0fe51d95b4b814f4f0e1a4..d96b3f32c885259ac9749cb4da1678154180415a 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
@@ -12,6 +12,8 @@ import org.chromium.chrome.browser.contextualsearch.ContextualSearchRankerLogger
 import org.chromium.chrome.browser.contextualsearch.ContextualSearchUma;
 import org.chromium.chrome.browser.contextualsearch.QuickActionCategory;
 
+import java.net.URL;
+
 /**
  * This class is responsible for all the logging related to Contextual Search.
  */
@@ -140,9 +142,9 @@ public class ContextualSearchPanelMetrics {
                 if (mRankerLogExperiments != null) {
                     mTapSuppressionRankerLogger.logOutcome(mWasSearchContentViewSeen);
                     mRankerLogExperiments.logRankerTapSuppression(mTapSuppressionRankerLogger);
-                    mTapSuppressionRankerLogger.writeLogAndReset();
                     mRankerLogExperiments = null;
                 }
+                mTapSuppressionRankerLogger.writeLogAndReset();

[Theresa, 2017/05/12 01:02:25]

Why was just this line pulled out of the if (mRankerLogExperiments != null)
block?

[Donn Denman, 2017/05/12 23:08:55]

I noticed that we log to Ranker in multiple places in this method, including
line 126 above, and so it might be possible to not complete a record if there
are no mRankerLoggerExperiments set but we did have mWasQuickActionClicked.  

Switched to a model where we must always call writeLogAndReset when ending
search, and have the RankerLogger keep track internally of whether anything was
written and and in this case start a new record.

[Theresa, 2017/05/18 15:35:11]

Will you please add a code comment with some of these details?

[Donn Denman, 2017/05/18 18:06:07]

Done.

 
                 ContextualSearchUma.logSelectionLengthResultsSeen(
                         mWasSearchContentViewSeen, mSelectionLength);
@@ -324,11 +326,14 @@ public class ContextualSearchPanelMetrics {
 
     /**
      * Sets the experiments to log through Ranker with results seen.
-     * @param rankerLogExperiments The experiments to log through ranker when the panel results
+     * @param rankerLogExperiments The experiments to log through Ranker when the panel results
      *        are known.
+     * @param basePageUrl The URL of the base page to log along with Ranker data.
      */
-    public void setRankerLogExperiments(ContextualSearchHeuristics rankerLogExperiments) {
+    public void setRankerLogExperiments(
+            ContextualSearchHeuristics rankerLogExperiments, URL basePageUrl) {
         mRankerLogExperiments = rankerLogExperiments;
+        mTapSuppressionRankerLogger.setBasePageUrl(basePageUrl);
     }
 
     /**