chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java - Issue 2857333002: [TTS] Write initial Tap-features to Ranker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java

Issue 2857333002: [TTS] Write initial Tap-features to Ranker. (Closed)

Patch Set: Reverted changes to translate_ranker_impl.cc and changed DVLOG(0) to DVLOG(3). Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLoggerImpl.java » ('j') | chrome/browser/android/contextualsearch/contextual_search_ranker_logger_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java

index 476c27018da33fad7509f15570f1553ca869c85c..1b0339fe879603a9e6dd471c6ea34b7ff5e14fec 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchRankerLogger.java

@@ -4,6 +4,8 @@

package org.chromium.chrome.browser.contextualsearch;

+import java.net.URL;

/**

* An interface for logging to UMA via Ranker.

@@ -27,6 +29,12 @@ public interface ContextualSearchRankerLogger {

SELECTION_FIRST_CHAR

}

+ /**

+ * Sets the URL for the page.

+ * @param basePageUrl The URL of the base page to log with Ranker.

+ */

+ void setBasePageUrl(URL basePageUrl);

/**

* Logs a particular key/value pair.

* @param feature The feature to log.