Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4688)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java

Issue 2857333002: [TTS] Write initial Tap-features to Ranker. (Closed)
Patch Set: Reverted changes to translate_ranker_impl.cc and changed DVLOG(0) to DVLOG(3). Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
index 42a0b063b5e3d37a1dc1dfdd653b9abfa1893883..41b262c048f30923fc52a32c0030f69372e8ede0 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
@@ -13,6 +13,7 @@ import org.chromium.chrome.browser.contextualsearch.ContextualSearchRankerLogger
import org.chromium.chrome.browser.contextualsearch.ContextualSearchUma;
import org.chromium.chrome.browser.contextualsearch.QuickActionCategory;
+import java.net.URL;
import java.util.Locale;
/**
@@ -153,9 +154,9 @@ public class ContextualSearchPanelMetrics {
writeSelectionFeaturesToRanker();
mTapSuppressionRankerLogger.logOutcome(mWasSearchContentViewSeen);
mRankerLogExperiments.logRankerTapSuppression(mTapSuppressionRankerLogger);
- mTapSuppressionRankerLogger.writeLogAndReset();
mRankerLogExperiments = null;
}
+ mTapSuppressionRankerLogger.writeLogAndReset();
ContextualSearchUma.logSelectionLengthResultsSeen(
mWasSearchContentViewSeen, mSelectionLength);
@@ -362,11 +363,14 @@ public class ContextualSearchPanelMetrics {
/**
* Sets the experiments to log through Ranker with results seen.
- * @param rankerLogExperiments The experiments to log through ranker when the panel results
+ * @param rankerLogExperiments The experiments to log through Ranker when the panel results
* are known.
+ * @param basePageUrl The URL of the base page to log along with Ranker data.
*/
- public void setRankerLogExperiments(ContextualSearchHeuristics rankerLogExperiments) {
+ public void setRankerLogExperiments(
+ ContextualSearchHeuristics rankerLogExperiments, URL basePageUrl) {
mRankerLogExperiments = rankerLogExperiments;
+ mTapSuppressionRankerLogger.setBasePageUrl(basePageUrl);
}
/**

Powered by Google App Engine
This is Rietveld 408576698