Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4038)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java

Issue 2857333002: [TTS] Write initial Tap-features to Ranker. (Closed)
Patch Set: Added an entry for CS and metrics written to ukm.xml. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
index 7495c0fd33331599fe0fe51d95b4b814f4f0e1a4..db79b6fc42aad80f60ee86b1d2112f952d2013dc 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelMetrics.java
@@ -12,6 +12,8 @@ import org.chromium.chrome.browser.contextualsearch.ContextualSearchRankerLogger
import org.chromium.chrome.browser.contextualsearch.ContextualSearchUma;
import org.chromium.chrome.browser.contextualsearch.QuickActionCategory;
+import java.net.URL;
+
/**
* This class is responsible for all the logging related to Contextual Search.
*/
@@ -121,7 +123,7 @@ public class ContextualSearchPanelMetrics {
mQuickActionCategory);
ContextualSearchUma.logQuickActionClicked(mWasQuickActionClicked,
mQuickActionCategory);
- mTapSuppressionRankerLogger.log(
+ mTapSuppressionRankerLogger.logOutcome(
ContextualSearchRankerLogger.Feature.OUTCOME_WAS_QUICK_ACTION_CLICKED,
mWasQuickActionClicked);
}
@@ -138,11 +140,15 @@ public class ContextualSearchPanelMetrics {
mWasSearchContentViewSeen, wasAnySuppressionHeuristicSatisfied);
// Log all the experiments to the Ranker logger.
if (mRankerLogExperiments != null) {
- mTapSuppressionRankerLogger.logOutcome(mWasSearchContentViewSeen);
+ mTapSuppressionRankerLogger.logOutcome(
+ ContextualSearchRankerLogger.Feature.OUTCOME_WAS_PANEL_OPENED,
+ mWasSearchContentViewSeen);
mRankerLogExperiments.logRankerTapSuppression(mTapSuppressionRankerLogger);
- mTapSuppressionRankerLogger.writeLogAndReset();
mRankerLogExperiments = null;
}
+ // Reset writing to Ranker so whatever interactions occurred are recorded as a
+ // complete record.
+ mTapSuppressionRankerLogger.writeLogAndReset();
ContextualSearchUma.logSelectionLengthResultsSeen(
mWasSearchContentViewSeen, mSelectionLength);
@@ -324,11 +330,14 @@ public class ContextualSearchPanelMetrics {
/**
* Sets the experiments to log through Ranker with results seen.
- * @param rankerLogExperiments The experiments to log through ranker when the panel results
+ * @param rankerLogExperiments The experiments to log through Ranker when the panel results
* are known.
+ * @param basePageUrl The URL of the base page to log along with Ranker data.
*/
- public void setRankerLogExperiments(ContextualSearchHeuristics rankerLogExperiments) {
+ public void setRankerLogExperiments(
+ ContextualSearchHeuristics rankerLogExperiments, URL basePageUrl) {
mRankerLogExperiments = rankerLogExperiments;
+ mTapSuppressionRankerLogger.setupLoggingForPage(basePageUrl);
}
/**

Powered by Google App Engine
This is Rietveld 408576698