Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 285733003: Remove a race between sweepers and the free space skipping code (while iterating new space pointers) (Closed)

Created:
6 years, 7 months ago by Jarin
Modified:
6 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove a race between sweepers and the free space skipping code (while iterating new space pointers). There has been a race between a sweeper setting the next pointer on free list node and the main thread skipping free space during update of new space pointers in the heap. This change removes the free space skipping code. R=hpayer@chromium.org BUG=370551 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21306

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -129 lines) Patch
M src/store-buffer.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/store-buffer.cc View 4 chunks +9 lines, -121 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 7 months ago (2014-05-14 10:26:26 UTC) #1
Hannes Payer (out of office)
LGTM if it does not tank performance. Can we describe in the subject what the ...
6 years, 7 months ago (2014-05-14 11:32:06 UTC) #2
Jarin
6 years, 7 months ago (2014-05-14 12:35:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21306 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698