third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp - Issue 2857303003: History API throws when serializing a SharedArrayBuffer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

Issue 2857303003: History API throws when serializing a SharedArrayBuffer (Closed)

Patch Set: merge HEAD Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

diff --git a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

index 1c67e1e5a869fd648506ba2a9178505ed018371a..c2485889d54eda3c3bbd4ef2aa87036f79eeab52 100644

--- a/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

+++ b/third_party/WebKit/Source/modules/indexeddb/IDBObjectStore.cpp

@@ -383,7 +383,7 @@ IDBRequest* IDBObjectStore::put(ScriptState* script_state,

// TODO(crbug.com/719053): This wasm behavior differs from other browsers.

options.write_wasm_to_stream =

ExecutionContext::From(script_state)->IsSecureContext();

- options.for_storage = true;

+ options.for_storage = SerializedScriptValue::kForStorage;

RefPtr<SerializedScriptValue> serialized_value =

SerializedScriptValue::Serialize(isolate, value.V8Value(), options,

exception_state);