[Mojo Video Capture] Implement a VideoCaptureProvider using the Mojo service (part 2)

content/browser/renderer_host/media/service_launched_video_capture_device.h

Index: content/browser/renderer_host/media/service_launched_video_capture_device.h
diff --git a/content/browser/renderer_host/media/service_launched_video_capture_device.h b/content/browser/renderer_host/media/service_launched_video_capture_device.h
index 6add459fd9c433b02c671ebbb562a66fe65f8960..8be3fb56ba70c890bc758004fd188e6dd63fd8f2 100644
--- a/content/browser/renderer_host/media/service_launched_video_capture_device.h
+++ b/content/browser/renderer_host/media/service_launched_video_capture_device.h
@@ -37,7 +37,10 @@ class ServiceLaunchedVideoCaptureDevice : public LaunchedVideoCaptureDevice {
   void OnUtilizationReport(int frame_feedback_id, double utilization) override;
 
  private:
-  const video_capture::mojom::DevicePtr device_;
+  void OnLostConnectionToDevice();
+
+  video_capture::mojom::DevicePtr device_;
+  base::ThreadChecker thread_checker_;

[miu, 2017/05/08 20:21:11]

Is this necessary? Seems like this class is single-threaded, and recent
discussions on chromium-dev@ suggested not using ThreadChecker on classes that
aren't meant to be multithreaded.

[chfremer, 2017/05/08 20:51:46]

I was not aware of that discussion and wasn't able to find it with a quick
search in chromium-dev. Could you please provide a link?

[chfremer, 2017/05/09 18:41:33]

Removed ThreadChecker here and in ServiceVideoCaptureDeviceLauncher.

[miu, 2017/05/09 19:34:19]

Here:
https://groups.google.com/a/chromium.org/forum/#!search/PSA$3A$20base$3A$3ANo...

[chfremer, 2017/05/09 20:49:01]

After reading the e-mail thread, my conclusion is that I misinterpreted your
initial comment. The recommendation here is not to simply remove any checking.
Instead, what we want is to use a base::SequenceChecker. I will add those back
in with a new PatchSet. Please let me know if you disagree.

 };
 
 }  // namespace content