Index: content/browser/renderer_host/media/service_video_capture_device_launcher.h |
diff --git a/content/browser/renderer_host/media/service_video_capture_device_launcher.h b/content/browser/renderer_host/media/service_video_capture_device_launcher.h |
index 6ef20ee68cde712f041ae77632f4ce3afb108ca6..e52d9e4bd284a57bfb72a3de3d7ad481bb8139c7 100644 |
--- a/content/browser/renderer_host/media/service_video_capture_device_launcher.h |
+++ b/content/browser/renderer_host/media/service_video_capture_device_launcher.h |
@@ -31,7 +31,30 @@ class ServiceVideoCaptureDeviceLauncher : public VideoCaptureDeviceLauncher { |
void OnUtilizationReport(int frame_feedback_id, double utilization); |
private: |
+ enum class State { |
+ READY_TO_LAUNCH, |
+ DEVICE_START_IN_PROGRESS, |
+ DEVICE_START_ABORTING |
+ }; |
+ |
+ void OnCreateDeviceCallback( |
+ const media::VideoCaptureParams& params, |
+ video_capture::mojom::DevicePtr device, |
+ base::WeakPtr<media::VideoFrameReceiver> receiver, |
+ Callbacks* callbacks, |
+ base::OnceClosure done_cb, |
+ video_capture::mojom::DeviceAccessResultCode result_code); |
+ void OnDeviceCreatedSuccessfully( |
+ const media::VideoCaptureParams& params, |
+ video_capture::mojom::DevicePtr device, |
+ base::WeakPtr<media::VideoFrameReceiver> receiver, |
+ Callbacks* callbacks, |
+ base::OnceClosure done_cb); |
+ void OnDeviceCreationFailed(Callbacks* callbacks, base::OnceClosure done_cb); |
mcasas
2017/05/05 22:41:02
Actually since OnDeviceCreatedSuccessfully()
and O
chfremer
2017/05/08 17:01:54
I wasn't aware that an "On" prefix is reserved for
miu
2017/05/08 20:21:11
FWIW, I tend to use:
OnSomething() - A method t
chfremer
2017/05/08 20:51:46
Looks reasonable (even though I am still not quite
mcasas
2017/05/08 21:08:04
Right. What I meant is that I'd rather use
OnTheEv
chfremer
2017/05/08 21:56:31
Hmm, the method OnCreateDeviceCallback() is also i
miu
2017/05/09 19:34:19
The caller. Always the caller. There are thousands
miu
2017/05/09 19:34:19
IMHO, OnSomething() is more for interfaces and the
|
+ |
video_capture::mojom::DeviceFactoryPtr* const device_factory_; |
+ State state_; |
+ base::ThreadChecker thread_checker_; |
}; |
} // namespace content |