Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2857233002: Implement more of the behavior of a plugin; refactor some API (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement more of the behavior of a plugin; refactor some API R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/84ca84b1a70700d2e2f707aa603ff0435099927c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+461 lines, -106 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/driver.dart View 8 chunks +34 lines, -35 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 12 chunks +144 lines, -66 lines 0 comments Download
A pkg/analyzer_plugin/test/plugin/plugin_test.dart View 1 chunk +278 lines, -0 lines 2 comments Download
A + pkg/analyzer_plugin/test/plugin/test_all.dart View 1 chunk +3 lines, -5 lines 0 comments Download
M pkg/analyzer_plugin/test/test_all.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Brian Wilkerson
This doesn't quite line up with our recent conversation about using AnalysisDriver, but I'd like ...
3 years, 7 months ago (2017-05-03 19:22:14 UTC) #2
scheglov
lgtm https://codereview.chromium.org/2857233002/diff/1/pkg/analyzer_plugin/test/plugin/plugin_test.dart File pkg/analyzer_plugin/test/plugin/plugin_test.dart (right): https://codereview.chromium.org/2857233002/diff/1/pkg/analyzer_plugin/test/plugin/plugin_test.dart#newcode59 pkg/analyzer_plugin/test/plugin/plugin_test.dart:59: resourceProvider.newFile(filePath1, ''); newFile() creates all its parent folders.
3 years, 7 months ago (2017-05-03 19:37:02 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/2857233002/diff/1/pkg/analyzer_plugin/test/plugin/plugin_test.dart File pkg/analyzer_plugin/test/plugin/plugin_test.dart (right): https://codereview.chromium.org/2857233002/diff/1/pkg/analyzer_plugin/test/plugin/plugin_test.dart#newcode59 pkg/analyzer_plugin/test/plugin/plugin_test.dart:59: resourceProvider.newFile(filePath1, ''); Done
3 years, 7 months ago (2017-05-03 19:48:12 UTC) #4
Brian Wilkerson
3 years, 7 months ago (2017-05-03 19:48:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
84ca84b1a70700d2e2f707aa603ff0435099927c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698