content/browser/frame_host/render_frame_host_manager.cc - Issue 2857213005: PlzNavigate: implement process reuse for ServiceWorkers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/render_frame_host_manager.cc

Issue 2857213005: PlzNavigate: implement process reuse for ServiceWorkers (Closed)

Patch Set: Addressed comments + fixed tests Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/render_frame_host_manager.cc

diff --git a/content/browser/frame_host/render_frame_host_manager.cc b/content/browser/frame_host/render_frame_host_manager.cc

index 8ab2e551bde024f90f81605062548a4146eab23b..2ec25629202fe552fd145168ca647d00211366bb 100644

--- a/content/browser/frame_host/render_frame_host_manager.cc

+++ b/content/browser/frame_host/render_frame_host_manager.cc

@@ -484,8 +484,8 @@ void RenderFrameHostManager::CommitPendingIfNecessary(

// https://code.google.com/p/chromium/issues/detail?id=75195

if (was_caused_by_user_gesture) {

if (IsBrowserSideNavigationEnabled()) {

- CleanUpNavigation();

frame_tree_node_->ResetNavigationRequest(false, true);

+ CleanUpNavigation();

} else {

CancelPending();

}