Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1660)

Unified Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 2857213005: PlzNavigate: implement process reuse for ServiceWorkers (Closed)
Patch Set: Addressed comments + fixed tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/render_frame_host_impl.h
diff --git a/content/browser/frame_host/render_frame_host_impl.h b/content/browser/frame_host/render_frame_host_impl.h
index 544ca969960be06e218b37cf594de7eae6c2eac3..e7c587d52ed196311a3267bf389f6965f65adae1 100644
--- a/content/browser/frame_host/render_frame_host_impl.h
+++ b/content/browser/frame_host/render_frame_host_impl.h
@@ -956,6 +956,11 @@ class CONTENT_EXPORT RenderFrameHostImpl
// Called by |beforeunload_timeout_| when the beforeunload timeout fires.
void BeforeUnloadTimeout();
+ // Called when a navigation commits succesfully to |url|. This will update
+ // |last_committed_site_url_| if it's not equal to the site url corresponding
+ // to |url|.
+ void SetLastCommittedSiteUrl(const GURL& url);
+
// For now, RenderFrameHosts indirectly keep RenderViewHosts alive via a
// refcount that calls Shutdown when it reaches zero. This allows each
// RenderFrameHostManager to just care about RenderFrameHosts, while ensuring
@@ -999,6 +1004,10 @@ class CONTENT_EXPORT RenderFrameHostImpl
// Track this frame's last committed origin.
url::Origin last_committed_origin_;
+ // Track the site URL of the last site we committed successfully, as obtained
+ // from SiteInstance::GetSiteURL.
+ GURL last_committed_site_url_;
+
// The most recent non-error URL to commit in this frame. Remove this in
// favor of GetLastCommittedURL() once PlzNavigate is enabled or cross-process
// transfers work for net errors. See https://crbug.com/588314.
« no previous file with comments | « content/browser/frame_host/navigator_impl_unittest.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698