PlzNavigate: implement process reuse for ServiceWorkers

content/browser/frame_host/render_frame_host_manager.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_manager.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <string>
@@ skipping 465 matching lines @@
 
     // If the current RenderFrameHost has a pending WebUI it must be committed.
     if (render_frame_host_->pending_web_ui())
       CommitPendingWebUI();
 
     // A navigation in the original page has taken place.  Cancel the pending
     // one. Only do it for user gesture originated navigations to prevent page
     // doing any shenanigans to prevent user from navigating.  See
     // https://code.google.com/p/chromium/issues/detail?id=75195
     if (was_caused_by_user_gesture) {
       if (IsBrowserSideNavigationEnabled()) {

[Charlie Reis, 2017/05/24 17:18:37]

Did this change cause
NavigatorTestWithBrowserSideNavigation.SimpleRendererInitiatedCrossSiteNavigation
to fail in --site-per-process plus PlzNavigate?

https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_iso...

(I wonder if that's just a test expectation question or if it represents a real
issue?)

[clamy, 2017/05/24 18:03:04]

NavigatorTestWithBrowserSideNavigation.SimpleRendererInitiatedCrossSiteNavigation
was wrong for --site-per-process and this exposed it. This has now been
corrected.

However, this change was not the right one: the call to CleanUpNavigation
shouldn't be removed but put after the call to ResetNavigationRequest (this made
other tests fail with PlzNavigate). All should be good now.

-        CleanUpNavigation();
         frame_tree_node_->ResetNavigationRequest(false, true);
       } else {
         CancelPending();
       }
     }
   } else {
     // No one else should be sending us DidNavigate in this state.
     NOTREACHED();
   }
 }
@@ skipping 2337 matching lines @@
           delegate_->IsHidden()) {
     if (delegate_->IsHidden()) {
       render_frame_host_->GetView()->Hide();
     } else {
       render_frame_host_->GetView()->Show();
     }
   }
 }
 
 }  // namespace content