PlzNavigate: implement process reuse for ServiceWorkers

content/browser/frame_host/render_frame_host_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 466 matching lines @@
 
 RenderFrameHostImpl::~RenderFrameHostImpl() {
   // Destroying navigation handle may call into delegates/observers,
   // so we do it early while |this| object is still in a sane state.
   navigation_handle_.reset();
 
   // Release the WebUI instances before all else as the WebUI may accesses the
   // RenderFrameHost during cleanup.
   ClearAllWebUI();
 
+  SetLastCommittedSiteUrl(GURL());
+
   GetProcess()->RemoveRoute(routing_id_);
   g_routing_id_frame_map.Get().erase(
       RenderFrameHostID(GetProcess()->GetID(), routing_id_));
 
   if (overlay_routing_token_)
     g_token_frame_map.Get().erase(*overlay_routing_token_);
 
   BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
                           base::Bind(&NotifyRenderFrameDetachedOnIO,
                                      GetProcess()->GetID(), routing_id_));
@@ skipping 949 matching lines @@
       frame_tree_node()->DidStartLoading(true, was_loading);
     }
     pending_commit_ = false;
   }
 
   // Find the appropriate NavigationHandle for this navigation.
   std::unique_ptr<NavigationHandleImpl> navigation_handle =
       TakeNavigationHandleForCommit(validated_params);
   DCHECK(navigation_handle);
 
+  // Update the site url if the navigation was successful.
+  if (navigation_handle->GetNetErrorCode() == net::OK)

[Charlie Reis, 2017/05/18 00:58:34]

NavigatorImpl::DidNavigate gates last_successful_url_ on
params.url_is_unreachable rather than net::OK.  Can those ever differ?  It's
better to use the same condition in both places if we can, and I'm not sure
which is better.

Also, perhaps we should set it to the empty GURL if the navigation was
unsuccessful, rather than leaving it as whatever it was before?

[clamy, 2017/05/22 16:59:52]

Done.

+    SetLastCommittedSiteUrl(navigation_handle->GetURL());
+
   // PlzNavigate sends searchable form data in the BeginNavigation message
   // while non-PlzNavigate sends it in the DidCommitProvisionalLoad message.
   // Update |navigation_handle| if necessary.
   if (!IsBrowserSideNavigationEnabled() &&
       !validated_params.searchable_form_url.is_empty()) {
     navigation_handle->set_searchable_form_url(
         validated_params.searchable_form_url);
     navigation_handle->set_searchable_form_encoding(
         validated_params.searchable_form_encoding);
 
@@ skipping 2443 matching lines @@
       false);                 // is_form_submission
 }
 
 void RenderFrameHostImpl::BeforeUnloadTimeout() {
   if (render_view_host_->GetDelegate()->ShouldIgnoreUnresponsiveRenderer())
     return;
 
   SimulateBeforeUnloadAck();
 }
 
+void RenderFrameHostImpl::SetLastCommittedSiteUrl(const GURL& url) {
+  BrowserContext* browser_context =
+      frame_tree_node_->navigator()->GetController()->GetBrowserContext();
+  GURL site_url = SiteInstance::GetSiteForURL(browser_context, url);
+
+  if (last_committed_site_url_ == url)
+    return;
+
+  if (!last_committed_site_url_.is_empty()) {
+    RenderProcessHostImpl::RemoveFrameWithSite(browser_context, GetProcess(),
+                                               last_committed_site_url_);
+  }
+
+  last_committed_site_url_ = site_url;
+
+  if (!last_committed_site_url_.is_empty()) {
+    RenderProcessHostImpl::AddFrameWithSite(browser_context, GetProcess(),
+                                            last_committed_site_url_);
+  }
+}
+
 #if defined(OS_ANDROID)
 
 class RenderFrameHostImpl::JavaInterfaceProvider
     : public service_manager::mojom::InterfaceProvider {
  public:
   JavaInterfaceProvider(
       const service_manager::BinderRegistry::Binder& bind_callback,
       service_manager::mojom::InterfaceProviderRequest request)
       : bind_callback_(bind_callback), binding_(this, std::move(request)) {}
   ~JavaInterfaceProvider() override = default;
@@ skipping 41 matching lines @@
 }
 
 void RenderFrameHostImpl::ForwardGetInterfaceToRenderFrame(
     const std::string& interface_name,
     mojo::ScopedMessagePipeHandle pipe) {
   GetRemoteInterfaces()->GetInterface(interface_name, std::move(pipe));
 }
 #endif
 
 }  // namespace content