Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 2857203002: Make the exit code for dartanalyzer more deterministic. (Closed)

Created:
3 years, 7 months ago by devoncarew
Modified:
3 years, 7 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the exit code for dartanalyzer more deterministic. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/5d0056df884632451c58ba6f9aac47e891405444

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -82 lines) Patch
M pkg/analyzer_cli/lib/src/analyzer_impl.dart View 3 chunks +5 lines, -10 lines 0 comments Download
M pkg/analyzer_cli/lib/src/build_mode.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer_cli/lib/src/driver.dart View 4 chunks +20 lines, -14 lines 0 comments Download
M pkg/analyzer_cli/lib/src/error_formatter.dart View 5 chunks +7 lines, -27 lines 0 comments Download
M pkg/analyzer_cli/lib/src/error_severity.dart View 2 chunks +14 lines, -27 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/error_upgrade_fails_cli/analysis_options.yaml View 1 chunk +3 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/error_upgrade_fails_cli/foo.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
A pkg/analyzer_cli/test/errors_upgrade_fails_cli_test.dart View 1 chunk +50 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
devoncarew
Make sure we do issue severity promotion for both the cli output and the exit ...
3 years, 7 months ago (2017-05-03 17:41:51 UTC) #2
Brian Wilkerson
lgtm
3 years, 7 months ago (2017-05-03 17:50:14 UTC) #3
devoncarew
Committed patchset #1 (id:1) manually as 5d0056df884632451c58ba6f9aac47e891405444 (presubmit successful).
3 years, 7 months ago (2017-05-03 18:38:42 UTC) #5
danrubel
3 years, 7 months ago (2017-05-03 20:58:24 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698