Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Unified Diff: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp

Issue 2857173003: Remove DocumentMarkerController::MarkersInRange() (Closed)
Patch Set: Use std::find_if() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
diff --git a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
index 3857308030c399a5366c91b2d15f82efec4b6eef..a92329bf541944938b166b1faf28152fb04af537 100644
--- a/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
+++ b/third_party/WebKit/Source/core/editing/InputMethodControllerTest.cpp
@@ -1408,16 +1408,18 @@ TEST_F(InputMethodControllerTest,
ASSERT_EQ(1u, GetDocument().Markers().Markers().size());
// Verify composition underline shows up on the second line, not the first
- ASSERT_EQ(0u, GetDocument()
- .Markers()
- .MarkersInRange(PlainTextRange(0, 5).CreateRange(*div),
- DocumentMarker::AllMarkers())
- .size());
- ASSERT_EQ(1u, GetDocument()
- .Markers()
- .MarkersInRange(PlainTextRange(6, 11).CreateRange(*div),
- DocumentMarker::AllMarkers())
- .size());
+ ASSERT_FALSE(
+ GetDocument()
+ .Markers()
+ .MarkerAtPosition(PlainTextRange(2).CreateRange(*div).StartPosition(),
+ DocumentMarker::AllMarkers())
+ .has_value());
+ ASSERT_TRUE(
+ GetDocument()
+ .Markers()
+ .MarkerAtPosition(PlainTextRange(8).CreateRange(*div).StartPosition(),
+ DocumentMarker::AllMarkers())
+ .has_value());
// Verify marker has correct start/end offsets (measured from the beginning
// of the node, which is the beginning of the line)

Powered by Google App Engine
This is Rietveld 408576698