Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: sdk/lib/html/dart2js/html_dart2js.dart

Issue 2857143003: dart2js_html: Fix for issue 29538 - some returned lists may be null (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/dart2js/html_dart2js.dart
diff --git a/sdk/lib/html/dart2js/html_dart2js.dart b/sdk/lib/html/dart2js/html_dart2js.dart
index 0c4080c4316debc3c99040f6669d0e08f477fbb3..a33c2dd4679e52103d56ef07c836eea2ef7372f6 100644
--- a/sdk/lib/html/dart2js/html_dart2js.dart
+++ b/sdk/lib/html/dart2js/html_dart2js.dart
@@ -1822,7 +1822,7 @@ class ButtonElement extends HtmlElement {
@DomName('HTMLButtonElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -3654,7 +3654,7 @@ class ContentElement extends HtmlElement {
@DomName('HTMLContentElement.getDistributedNodes')
@DocsEditable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
List<Node> getDistributedNodes() native;
}
@@ -4002,7 +4002,7 @@ class CssGroupingRule extends CssRule {
@DomName('CSSGroupingRule.cssRules')
@DocsEditable()
@Experimental() // untriaged
- @Returns('_CssRuleList')
+ @Returns('_CssRuleList|Null')
@Creates('_CssRuleList')
final List<CssRule> cssRules;
@@ -4082,7 +4082,7 @@ class CssKeyframesRule extends CssRule {
@DomName('CSSKeyframesRule.cssRules')
@DocsEditable()
@Experimental() // untriaged
- @Returns('_CssRuleList')
+ @Returns('_CssRuleList|Null')
@Creates('_CssRuleList')
final List<CssRule> cssRules;
@@ -8731,7 +8731,7 @@ class CssStyleSheet extends StyleSheet {
@DomName('CSSStyleSheet.cssRules')
@DocsEditable()
- @Returns('_CssRuleList')
+ @Returns('_CssRuleList|Null')
@Creates('_CssRuleList')
final List<CssRule> cssRules;
@@ -8742,7 +8742,7 @@ class CssStyleSheet extends StyleSheet {
@DomName('CSSStyleSheet.rules')
@DocsEditable()
@Experimental() // non-standard
- @Returns('_CssRuleList')
+ @Returns('_CssRuleList|Null')
@Creates('_CssRuleList')
final List<CssRule> rules;
@@ -8783,7 +8783,7 @@ class CssSupportsRule extends CssRule {
@DomName('CSSSupportsRule.cssRules')
@DocsEditable()
- @Returns('_CssRuleList')
+ @Returns('_CssRuleList|Null')
@Creates('_CssRuleList')
final List<CssRule> cssRules;
@@ -8947,7 +8947,7 @@ class DataListElement extends HtmlElement {
@DomName('HTMLDataListElement.options')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> options;
}
@@ -8978,7 +8978,7 @@ class DataTransfer extends Interceptor {
@DomName('DataTransfer.files')
@DocsEditable()
@Experimental() // untriaged
- @Returns('FileList')
+ @Returns('FileList|Null')
@Creates('FileList')
final List<File> files;
@@ -9994,7 +9994,7 @@ class Document extends Node {
@JSName('styleSheets')
@DomName('Document.styleSheets')
@DocsEditable()
- @Returns('_StyleSheetList')
+ @Returns('_StyleSheetList|Null')
@Creates('_StyleSheetList')
final List<StyleSheet> _styleSheets;
@@ -10231,7 +10231,7 @@ class Document extends Node {
@JSName('children')
@DomName('Document.children')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> _children;
@@ -10269,8 +10269,8 @@ class Document extends Node {
@JSName('querySelectorAll')
@DomName('Document.querySelectorAll')
@DocsEditable()
- @Returns('NodeList')
@Creates('NodeList')
+ @Returns('NodeList')
List<Node> _querySelectorAll(String selectors) native;
/// Stream of `abort` events handled by this [Document].
@@ -10926,8 +10926,8 @@ class DocumentFragment extends Node
@JSName('querySelectorAll')
@DomName('DocumentFragment.querySelectorAll')
@DocsEditable()
- @Returns('NodeList')
@Creates('NodeList')
+ @Returns('NodeList')
List<Node> _querySelectorAll(String selectors) native;
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -15328,7 +15328,7 @@ class Element extends Node
*/
@DomName('Element.getClientRects')
@DocsEditable()
- @Returns('_ClientRectList')
+ @Returns('_ClientRectList|Null')
@Creates('_ClientRectList')
List<Rectangle> getClientRects() native;
@@ -15345,7 +15345,7 @@ class Element extends Node
@DomName('Element.getDestinationInsertionPoints')
@DocsEditable()
@Experimental() // untriaged
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
List<Node> getDestinationInsertionPoints() native;
@@ -15561,7 +15561,7 @@ class Element extends Node
@JSName('children')
@DomName('Element.children')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> _children;
@@ -15598,8 +15598,8 @@ class Element extends Node
@JSName('querySelectorAll')
@DomName('Element.querySelectorAll')
@DocsEditable()
- @Returns('NodeList')
@Creates('NodeList')
+ @Returns('NodeList')
List<Node> _querySelectorAll(String selectors) native;
/// Stream of `abort` events handled by this [Element].
@@ -20427,7 +20427,7 @@ class HttpRequest extends HttpRequestEventTarget {
void send([body_OR_data]) native;
/**
- * Sets the value of an HTTP request header.
+ * Sets the value of an HTTP requst header.
*
* This method should be called after the request is opened, but before
* the request is sent.
@@ -20992,7 +20992,7 @@ class InputElement extends HtmlElement
@DomName('HTMLInputElement.files')
@DocsEditable()
- @Returns('FileList')
+ @Returns('FileList|Null')
@Creates('FileList')
List<File> files;
@@ -21041,7 +21041,7 @@ class InputElement extends HtmlElement
@DomName('HTMLInputElement.labels')
@DocsEditable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -22039,7 +22039,7 @@ class KeygenElement extends HtmlElement {
@DomName('HTMLKeygenElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -22270,7 +22270,7 @@ class Location extends Interceptor implements LocationBase {
@DomName('Location.ancestorOrigins')
@DocsEditable()
@Experimental() // nonstandard
- @Returns('DomStringList')
+ @Returns('DomStringList|Null')
@Creates('DomStringList')
final List<String> ancestorOrigins;
@@ -22356,7 +22356,7 @@ class MapElement extends HtmlElement {
@DomName('HTMLMapElement.areas')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> areas;
@@ -24204,7 +24204,7 @@ class MeterElement extends HtmlElement {
@DomName('HTMLMeterElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -25030,7 +25030,7 @@ class MutationRecord extends Interceptor {
@DomName('MutationRecord.addedNodes')
@DocsEditable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> addedNodes;
@@ -25056,7 +25056,7 @@ class MutationRecord extends Interceptor {
@DomName('MutationRecord.removedNodes')
@DocsEditable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> removedNodes;
@@ -25267,7 +25267,7 @@ class Navigator extends Interceptor
@DomName('Navigator.getGamepads')
@DocsEditable()
@Experimental() // untriaged
- @Returns('_GamepadList')
+ @Returns('_GamepadList|Null')
@Creates('_GamepadList')
List<Gamepad> getGamepads() native;
@@ -26847,7 +26847,7 @@ class OutputElement extends HtmlElement {
@DomName('HTMLOutputElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -28318,7 +28318,7 @@ class ProgressElement extends HtmlElement {
@DomName('HTMLProgressElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -28743,7 +28743,7 @@ class Range extends Interceptor {
@DomName('Range.getClientRects')
@DocsEditable()
- @Returns('_ClientRectList')
+ @Returns('_ClientRectList|Null')
@Creates('_ClientRectList')
List<Rectangle> getClientRects() native;
@@ -30239,7 +30239,7 @@ class SelectElement extends HtmlElement {
@DomName('HTMLSelectElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -30971,7 +30971,7 @@ class ShadowElement extends HtmlElement {
@DomName('HTMLShadowElement.getDistributedNodes')
@DocsEditable()
@Experimental() // untriaged
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
List<Node> getDistributedNodes() native;
}
@@ -31019,7 +31019,7 @@ class ShadowRoot extends DocumentFragment {
@DomName('ShadowRoot.styleSheets')
@DocsEditable()
@Experimental() // untriaged
- @Returns('_StyleSheetList')
+ @Returns('_StyleSheetList|Null')
@Creates('_StyleSheetList')
final List<StyleSheet> styleSheets;
@@ -31906,7 +31906,7 @@ class SpeechRecognitionEvent extends Event {
@DomName('SpeechRecognitionEvent.results')
@DocsEditable()
- @Returns('_SpeechRecognitionResultList')
+ @Returns('_SpeechRecognitionResultList|Null')
@Creates('_SpeechRecognitionResultList')
final List<SpeechRecognitionResult> results;
}
@@ -32961,14 +32961,14 @@ class TableElement extends HtmlElement {
@JSName('rows')
@DomName('HTMLTableElement.rows')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> _rows;
@JSName('tBodies')
@DomName('HTMLTableElement.tBodies')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> _tBodies;
@@ -33074,7 +33074,7 @@ class TableRowElement extends HtmlElement {
@JSName('cells')
@DomName('HTMLTableRowElement.cells')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> _cells;
@@ -33143,7 +33143,7 @@ class TableSectionElement extends HtmlElement {
@JSName('rows')
@DomName('HTMLTableSectionElement.rows')
@DocsEditable()
- @Returns('HtmlCollection')
+ @Returns('HtmlCollection|Null')
@Creates('HtmlCollection')
final List<Node> _rows;
@@ -33233,7 +33233,7 @@ class Text extends CharacterData {
@DomName('Text.getDestinationInsertionPoints')
@DocsEditable()
@Experimental() // untriaged
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
List<Node> getDestinationInsertionPoints() native;
@@ -33307,7 +33307,7 @@ class TextAreaElement extends HtmlElement {
@DomName('HTMLTextAreaElement.labels')
@DocsEditable()
@Unstable()
- @Returns('NodeList')
+ @Returns('NodeList|Null')
@Creates('NodeList')
final List<Node> labels;
@@ -36879,7 +36879,7 @@ class Window extends EventTarget
@DomName('Window.getMatchedCSSRules')
@DocsEditable()
@Experimental() // non-standard
- @Returns('_CssRuleList')
+ @Returns('_CssRuleList|Null')
@Creates('_CssRuleList')
List<CssRule> getMatchedCssRules(Element element, String pseudoElement)
native;
« no previous file with comments | « no previous file | sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698