dart2js: Improve code quality after min/max changes

dart2js: Improve code quality after min/max changes

The new definition gets inlined, which can cause the code to be
bigger.  Characterizing the JavaScript allows better scheduling around
the expression.

Making checkNum no-inline prevents inlining control flow that confuses
other optimizations.  Since the optimizer already understands when to
eliminate checkNum calls, this is not a problem.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/sdk/commit/e3436ada00d355ea2d3b8df224873857004eba8a

[sra1, 2017-05-05 23:52:05]

sra@google.com changed reviewers:
+ rnystrom@google.com, sigmund@google.com

[sra1, 2017-05-05 23:52:20]

Description was changed from

==========
dart2js: Improve code quality after min/max changes

The new definition gets inlined, which can cause teh code to be
bigger.  Characterizing the JavaScript allows better scheduling around
the expression.

Making checkNum no-inline prevents inlining control flow that confuses
other optimizations.  Since the optimizer already understands when to
eliminate checkNum calls, this is not a problem.
==========

to

==========
dart2js: Improve code quality after min/max changes

The new definition gets inlined, which can cause the code to be
bigger.  Characterizing the JavaScript allows better scheduling around
the expression.

Making checkNum no-inline prevents inlining control flow that confuses
other optimizations.  Since the optimizer already understands when to
eliminate checkNum calls, this is not a problem.
==========

[Bob Nystrom, 2017-05-05 23:55:12]

lgtm

[sra1, 2017-05-06 00:21:15]

Description was changed from

==========
dart2js: Improve code quality after min/max changes

The new definition gets inlined, which can cause the code to be
bigger.  Characterizing the JavaScript allows better scheduling around
the expression.

Making checkNum no-inline prevents inlining control flow that confuses
other optimizations.  Since the optimizer already understands when to
eliminate checkNum calls, this is not a problem.
==========

to

==========
dart2js: Improve code quality after min/max changes

The new definition gets inlined, which can cause the code to be
bigger.  Characterizing the JavaScript allows better scheduling around
the expression.

Making checkNum no-inline prevents inlining control flow that confuses
other optimizations.  Since the optimizer already understands when to
eliminate checkNum calls, this is not a problem.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e3436ada00d355ea2d3b8df224873857004eba8a
==========

[sra1, 2017-05-06 00:21:16]

Committed patchset #2 (id:20001) manually as
e3436ada00d355ea2d3b8df224873857004eba8a (presubmit successful).

[Siggi Cherem (dart-lang), 2017-05-08 22:28:45]

lgtm