Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2857133004: Change Accessor(s) to use AstFactory to create MethodInvocation, PropertyGet/Set. (Closed)

Created:
3 years, 7 months ago by scheglov
Modified:
3 years, 7 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change Accessor(s) to use AstFactory to create MethodInvocation, PropertyGet/Set. R=ahe@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/b567aeaeef841a99b21e77ca0d60261809481151

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -150 lines) Patch
M pkg/analysis_server/analysis_server.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer_cli/analyzer_cli.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/front_end.iml View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/ast_factory.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 5 chunks +12 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 18 chunks +49 lines, -50 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 22 chunks +112 lines, -87 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_ast_factory.dart View 2 chunks +19 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 3 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 7 months ago (2017-05-03 19:42:39 UTC) #1
Paul Berry
lgtm
3 years, 7 months ago (2017-05-03 20:54:13 UTC) #2
scheglov
3 years, 7 months ago (2017-05-03 21:10:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b567aeaeef841a99b21e77ca0d60261809481151 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698