ios/chrome/browser/ui/content_suggestions/BUILD.gn - Issue 2857123003: Move frame-related methods out of GoogleLandingViewController

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/content_suggestions/BUILD.gn

Issue 2857123003: Move frame-related methods out of GoogleLandingViewController (Closed)

Patch Set: Address comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h » ('j') | ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/content_suggestions/BUILD.gn

diff --git a/ios/chrome/browser/ui/content_suggestions/BUILD.gn b/ios/chrome/browser/ui/content_suggestions/BUILD.gn

index 42381edb149a5223a72b1bcec3f962ea0bd360bd..2d6de7bd14e1b56d1713627ce1bdcb1dfbe33caa 100644

--- a/ios/chrome/browser/ui/content_suggestions/BUILD.gn

+++ b/ios/chrome/browser/ui/content_suggestions/BUILD.gn

@@ -10,6 +10,8 @@ source_set("content_suggestions") {

"content_suggestion_extra_builder.mm",

"content_suggestions_collection_updater.h",

"content_suggestions_collection_updater.mm",

+ "content_suggestions_collection_utils.h",

+ "content_suggestions_collection_utils.mm",

"content_suggestions_commands.h",

"content_suggestions_data_sink.h",

"content_suggestions_data_source.h",

@@ -21,6 +23,7 @@ source_set("content_suggestions") {

":resources",

"//base",

"//components/strings",

+ "//ios/chrome/browser/ui",

"//ios/chrome/browser/ui/collection_view",

"//ios/chrome/browser/ui/content_suggestions/cells",

"//ios/chrome/browser/ui/content_suggestions/identifier",

@@ -39,12 +42,15 @@ source_set("unit_tests") {

testonly = true

sources = [

"content_suggestions_collection_updater_unittest.mm",

+ "content_suggestions_collection_utils_unittest.mm",

]

deps = [

":content_suggestions",

"//base",

+ "//ios/chrome/browser/ui",

"//ios/chrome/browser/ui/collection_view",

"//ios/chrome/browser/ui/content_suggestions/identifier",

+ "//ios/chrome/test/base",

"//testing/gtest",

"//third_party/ocmock",

]