Move frame-related methods out of GoogleLandingViewController

ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils_unittest.mm

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#import "ios/chrome/browser/ui/content_suggestions/content_suggestions_collection_utils.h"
+
+#include "base/memory/ptr_util.h"
+#include "ios/chrome/browser/ui/ui_util.h"
+#import "ios/chrome/test/base/scoped_block_swizzler.h"
+#include "testing/platform_test.h"
+#import "third_party/ocmock/OCMock/OCMock.h"
+
+#if !defined(__has_feature) || !__has_feature(objc_arc)
+#error "This file requires ARC support."
+#endif
+
+namespace content_suggestions {
+
+TEST(ContentSuggestionsCollectionUtilsTest, orientationFramePortrait) {
+  // Setup.
+  CGRect rect1 = CGRectMake(10, 10, 0, 10);
+  CGRect rect2 = CGRectMake(20, 20, 0, 20);
+  const CGRect rects[2] = {rect1, rect2};
+
+  // Action.
+  CGRect result = getOrientationFrame(rects, 400);
+
+  // Tests.
+  rect1.size.width = 380;
+  EXPECT_TRUE(CGRectEqualToRect(rect1, result));
+}
+
+TEST(ContentSuggestionsCollectionUtilsTest, orientationFrameLandscape) {
+  // Setup.
+  CGRect rect1 = CGRectMake(10, 10, 0, 10);
+  CGRect rect2 = CGRectMake(20, 20, 0, 20);
+  const CGRect rects[2] = {rect1, rect2};
+  std::unique_ptr<ScopedBlockSwizzler> safe_mode_swizzler_ =

[marq (ping after 24h), 2017/05/10 09:23:49]

orientation_swizzler seems like a better name.

Also, this isn't a member variable, so no trailing underscore.

[gambard, 2017/05/10 11:09:40]

Done.

+      base::MakeUnique<ScopedBlockSwizzler>(
+          [UIApplication class], @selector(statusBarOrientation),
+          ^UIInterfaceOrientation(id self) {
+            return UIInterfaceOrientationLandscapeLeft;
+          });
+
+  // Action.
+  CGRect result = getOrientationFrame(rects, 400);
+
+  // Tests.
+  rect1.size.width = 380;
+  rect2.size.width = 360;
+  if (IsIPadIdiom()) {
+    EXPECT_TRUE(CGRectEqualToRect(rect1, result));
+  } else {
+    EXPECT_TRUE(CGRectEqualToRect(rect2, result));
+  }
+}
+
+TEST(ContentSuggestionsCollectionUtilsTest, centeredTilesMarginIPhone6) {
+  // Setup.
+  if (IsIPadIdiom())
+    return;
+
+  // Action.
+  CGFloat result = centeredTilesMarginForWidth(374);
+
+  // Tests.
+  EXPECT_EQ(17, result);
+}
+
+TEST(ContentSuggestionsCollectionUtilsTest, centeredTilesMarginIPad) {
+  // Setup.
+  if (!IsIPadIdiom())

[marq (ping after 24h), 2017/05/10 09:23:49]

Can you swizzle UIDevice's -userInterfaceIdiom to exercise the various
IsIPadIdiom code paths without putting conditionals in the tests?

(I'm fine for that to be in a follow-up CL).

[gambard, 2017/05/10 11:09:40]

Done.

+    return;
+
+  // Action.
+  CGFloat result = centeredTilesMarginForWidth(700);
+
+  // Tests.
+  EXPECT_EQ(168, result);
+}
+
+TEST(ContentSuggestionsCollectionUtilsTest, doodleFrame) {
+  // Setup.
+  CGFloat yValue = 66;
+  if (IsIPadIdiom())
+    yValue = 82;
+
+  // Action.
+  CGRect result = doodleFrame(500, YES);
+
+  // Test.
+  EXPECT_TRUE(CGRectEqualToRect(CGRectMake(0, yValue, 500, 120), result));
+}
+
+TEST(ContentSuggestionsCollectionUtilsTest, searchFieldFrame) {
+  // Setup.
+  CGFloat width = 500;
+  CGFloat margin = centeredTilesMarginForWidth(width);
+  CGFloat offset = 0;
+  if (IsIPadIdiom())
+    offset = 66;
+
+  // Action.
+  CGRect result = searchFieldFrame(width, YES);
+
+  // Test.
+  EXPECT_TRUE(CGRectEqualToRect(
+      CGRectMake(margin, 218 + offset, 500 - 2 * margin, 50), result));
+}
+
+TEST(ContentSuggestionsCollectionUtilsTest, heightForLogoHeader) {
+  // Setup.
+  CGFloat yValue = 284;
+  CGFloat offset = 0;
+  if (IsIPadIdiom()) {
+    yValue = 350;
+    offset = 56;
+  }
+
+  // Action, tests.
+  EXPECT_EQ(yValue, heightForLogoHeader(500, YES, YES));
+  EXPECT_EQ(yValue + offset, heightForLogoHeader(500, YES, NO));
+}
+
+}  // namespace content_suggestions