[Night Light] CL2: Ash and system tray work

ash/system/tiles/tray_tiles_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/system/tiles/tray_tiles.h"
 
 #include "ash/system/tiles/tiles_default_view.h"
 #include "ash/test/ash_test_base.h"
 #include "ash/test/test_session_controller_client.h"
 #include "components/user_manager/user_type.h"
@@ skipping 21 matching lines @@
   }
 
   views::CustomButton* GetSettingsButton() {
     return tray_tiles()->default_view_->settings_button_;
   }
 
   views::CustomButton* GetHelpButton() {
     return tray_tiles()->default_view_->help_button_;
   }
 
+  views::CustomButton* GetNightLightButton() {
+    return tray_tiles()->default_view_->night_light_button_;
+  }
+
   views::CustomButton* GetLockButton() {
     return tray_tiles()->default_view_->lock_button_;
   }
 
   views::CustomButton* GetPowerButton() {
     return tray_tiles()->default_view_->power_button_;
   }
 
   TrayTiles* tray_tiles() { return tray_tiles_.get(); }
 
  private:
   std::unique_ptr<TrayTiles> tray_tiles_;
 
   DISALLOW_COPY_AND_ASSIGN(TrayTilesTest);
 };
 
 // Settings buttons are disabled before login.
 TEST_F(TrayTilesTest, ButtonStatesNotLoggedIn) {
   std::unique_ptr<views::View> default_view(
       tray_tiles()->CreateDefaultViewForTesting());
   EXPECT_EQ(Button::STATE_DISABLED, GetSettingsButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetHelpButton()->state());
+  EXPECT_EQ(Button::STATE_DISABLED, GetNightLightButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetLockButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetPowerButton()->state());
 }
 
 // All buttons are enabled after login.
 TEST_F(TrayTilesTest, ButtonStatesLoggedIn) {
   SetSessionStarted(true);
   std::unique_ptr<views::View> default_view(
       tray_tiles()->CreateDefaultViewForTesting());
   EXPECT_EQ(Button::STATE_NORMAL, GetSettingsButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetHelpButton()->state());
+  EXPECT_EQ(Button::STATE_NORMAL, GetNightLightButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetLockButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetPowerButton()->state());
 }
 
 // Settings buttons are disabled at the lock screen.
 TEST_F(TrayTilesTest, ButtonStatesLockScreen) {
   BlockUserSession(BLOCKED_BY_LOCK_SCREEN);
   std::unique_ptr<views::View> default_view(
       tray_tiles()->CreateDefaultViewForTesting());
   EXPECT_EQ(Button::STATE_DISABLED, GetSettingsButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetHelpButton()->state());
+  EXPECT_EQ(Button::STATE_DISABLED, GetNightLightButton()->state());

[James Cook, 2017/05/05 20:47:43]

Any particular reason this feature is disabled at the lock screen? Just so the
buttons look the same?

[afakhry, 2017/05/06 00:49:35]

I guess so. I think I'll have to check again with Olga when she comes back next
week to see if we want users to be able to toggle it on or off at lock screen.

This is however is consistent with the other buttons, including the Settings
button, and the Night Light button is a shortcut to one of the settings. But I
can check and modify it later. There are several CLs coming up.

[James Cook, 2017/05/08 16:09:07]

Ah. It wasn't clear to me from the videos / mocks that the icon opened the
settings. I thought it toggled the feature on and off when clicked.

[afakhry, 2017/05/08 17:36:26]

Oh, sorry, I think I confused even more! You are right. The button does NOT open
settings. It only toggles the feature on and off.

What I meant was, we don't want that button to be enabled when the user is not
logged in, similarly to the settings button, since the NightLight button
controls a user setting value, and for that we need the user to be logged in.

   EXPECT_EQ(Button::STATE_DISABLED, GetLockButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetPowerButton()->state());
 }
 
 // Settings buttons are disabled when adding a second multiprofile user.
 TEST_F(TrayTilesTest, ButtonStatesAddingUser) {
   SetUserAddingScreenRunning(true);
   std::unique_ptr<views::View> default_view(
       tray_tiles()->CreateDefaultViewForTesting());
   EXPECT_EQ(Button::STATE_DISABLED, GetSettingsButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetHelpButton()->state());
+  EXPECT_EQ(Button::STATE_DISABLED, GetNightLightButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetLockButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetPowerButton()->state());
 }
 
 // Settings buttons are disabled when adding a supervised user.
 TEST_F(TrayTilesTest, ButtonStatesSupervisedUserFlow) {
   // Simulate the add supervised user flow, which is a regular user session but
   // with web UI settings disabled.
   const bool enable_settings = false;
   GetSessionControllerClient()->AddUserSession(
       "foo@example.com", user_manager::USER_TYPE_REGULAR, enable_settings);
   std::unique_ptr<views::View> default_view(
       tray_tiles()->CreateDefaultViewForTesting());
   EXPECT_EQ(Button::STATE_DISABLED, GetSettingsButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetHelpButton()->state());
+  EXPECT_EQ(Button::STATE_DISABLED, GetNightLightButton()->state());
   EXPECT_EQ(Button::STATE_DISABLED, GetLockButton()->state());
   EXPECT_EQ(Button::STATE_NORMAL, GetPowerButton()->state());
 }
 
 }  // namespace ash